Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Unified Diff: src/factory.cc

Issue 1417063011: [runtime] support new Proxy() instead of Proxy.create and install getPrototypeOf trap (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: using one friend less Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/factory.cc
diff --git a/src/factory.cc b/src/factory.cc
index 595259b3aaf85831f639cee7b4db2f9360ba4ccc..e7a00a6fca09eda77aa71dbc7682fc87f476ca29 100644
--- a/src/factory.cc
+++ b/src/factory.cc
@@ -1936,13 +1936,13 @@ Handle<JSDataView> Factory::NewJSDataView(Handle<JSArrayBuffer> buffer,
}
-Handle<JSProxy> Factory::NewJSProxy(Handle<Object> handler,
- Handle<Object> prototype) {
+Handle<JSProxy> Factory::NewJSProxy(Handle<Object> target,
+ Handle<Object> handler) {
// Allocate map.
// TODO(rossberg): Once we optimize proxies, think about a scheme to share
// maps. Will probably depend on the identity of the handler object, too.
Handle<Map> map = NewMap(JS_PROXY_TYPE, JSProxy::kSize);
- Map::SetPrototype(map, prototype);
+ Map::SetPrototype(map, target);
rossberg 2015/11/12 17:04:39 Not sure that makes sense. For the new proxy seman
Camillo Bruni 2015/11/12 20:20:55 same as above, will go away.
// Allocate the proxy object.
Handle<JSProxy> result = New<JSProxy>(map, NEW_SPACE);

Powered by Google App Engine
This is Rietveld 408576698