Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: src/messages.h

Issue 1417063011: [runtime] support new Proxy() instead of Proxy.create and install getPrototypeOf trap (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: adding proxy trap strings Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/messages.h
diff --git a/src/messages.h b/src/messages.h
index 6d3f797822d4967cb033818d281b5c8aeee54df4..4b0907bb9db58cad13081597439bad66fbf460ab 100644
--- a/src/messages.h
+++ b/src/messages.h
@@ -182,13 +182,13 @@ class CallSite {
"Class extends value does not have valid prototype property %") \
T(ProxyHandlerDeleteFailed, \
"Proxy handler % did not return a boolean value from 'delete' trap") \
- T(ProxyHandlerNonObject, "Proxy.% called with non-object as handler") \
+ T(ProxyTargetNonObject, "Proxy.% called with non-object as target") \
Jakob Kummerow 2015/11/12 12:04:24 nit: please alpha-sort
T(ProxyHandlerReturned, "Proxy handler % returned % from '%' trap") \
T(ProxyHandlerTrapMissing, "Proxy handler % has no '%' trap") \
T(ProxyHandlerTrapMustBeCallable, \
"Proxy handler %0 has non-callable '%' trap") \
T(ProxyNonObjectPropNames, "Trap '%' returned non-object %") \
- T(ProxyProtoNonObject, "Proxy.create called with no-object as prototype") \
+ T(ProxyHandlerNonObject, "Proxy.create called with no-object as handler") \
Jakob Kummerow 2015/11/12 12:04:24 nit: please alpha-sort
T(ProxyPropNotConfigurable, \
"Proxy handler % returned non-configurable descriptor for property '%' " \
"from '%' trap") \

Powered by Google App Engine
This is Rietveld 408576698