Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Unified Diff: cc/trees/channel_main.h

Issue 1417053005: cc: Split ThreadProxy into ProxyMain and ProxyImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/trees/channel_main.h
diff --git a/cc/trees/channel_main.h b/cc/trees/channel_main.h
index 9c6689c1c4f4c6f9e993494fa725472e06df1046..6ff6fab114f19c54b80a4544314aab14f388d31c 100644
--- a/cc/trees/channel_main.h
+++ b/cc/trees/channel_main.h
@@ -9,10 +9,12 @@
#include "cc/base/completion_event.h"
#include "cc/input/top_controls_state.h"
#include "cc/output/output_surface.h"
+#include "cc/scheduler/begin_frame_source.h"
#include "cc/scheduler/commit_earlyout_reason.h"
#include "cc/trees/proxy_common.h"
namespace cc {
+
// ChannelMain and ChannelImpl provide an abstract communication layer for
// the main and impl side of the compositor.
//
@@ -47,9 +49,15 @@ class CC_EXPORT ChannelMain {
virtual void StartCommitOnImpl(CompletionEvent* completion,
LayerTreeHost* layer_tree_host,
bool hold_commit_for_activation) = 0;
- virtual void InitializeImplOnImpl(CompletionEvent* completion,
- LayerTreeHost* layer_tree_host) = 0;
- virtual void LayerTreeHostClosedOnImpl(CompletionEvent* completion) = 0;
+
+ // Must be called before using the channel.
+ virtual void InitializeImpl(
+ CompletionEvent* completion,
+ LayerTreeHost* layer_tree_host,
+ scoped_ptr<BeginFrameSource> external_begin_frame_source) = 0;
+ // Must be called before deleting the channel.
+ virtual void CloseImpl(CompletionEvent* completion) = 0;
+ virtual bool IsInitialized() const = 0;
Wez 2015/11/10 01:41:50 nit: Suggest separating the three methods with bla
Khushal 2015/11/11 04:17:47 Done.
virtual ~ChannelMain() {}
};

Powered by Google App Engine
This is Rietveld 408576698