Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 1417043006: [turbofan] Split JSGlobalObjectSpecialization into separate class. (Closed)

Created:
5 years, 1 month ago by Benedikt Meurer
Modified:
5 years, 1 month ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Split JSGlobalObjectSpecialization into separate class. The JSNativeContextSpecialization class is getting rather huge with all the stuff related to property and element access going in. Splitting off the global object related stuff into JSGlobalObjectSpecialization seems like a natural separation, especially since the global object specialization is sort of separate issue anyway. This is neutral functionality- and performance-wise. R=jarin@chromium.org BUG=v8:4470 LOG=n Committed: https://crrev.com/4eb41ba7385a594e7b17ce6a4f0ed4b039ccec8f Cr-Commit-Position: refs/heads/master@{#31748}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+413 lines, -252 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A src/compiler/js-global-object-specialization.h View 1 chunk +84 lines, -0 lines 0 comments Download
A src/compiler/js-global-object-specialization.cc View 1 chunk +294 lines, -0 lines 0 comments Download
M src/compiler/js-inlining.cc View 2 chunks +10 lines, -2 lines 0 comments Download
M src/compiler/js-native-context-specialization.h View 7 chunks +2 lines, -17 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 7 chunks +8 lines, -232 lines 0 comments Download
M src/compiler/pipeline.cc View 2 chunks +11 lines, -1 line 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 1 month ago (2015-11-03 13:29:29 UTC) #1
Benedikt Meurer
Hey Jaro, As mentioned before, I'm splitting the native context specialization into global specialization and ...
5 years, 1 month ago (2015-11-03 13:30:32 UTC) #2
Jarin
lgtm
5 years, 1 month ago (2015-11-03 13:30:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417043006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417043006/1
5 years, 1 month ago (2015-11-03 13:30:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-03 14:20:19 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-03 14:20:47 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4eb41ba7385a594e7b17ce6a4f0ed4b039ccec8f
Cr-Commit-Position: refs/heads/master@{#31748}

Powered by Google App Engine
This is Rietveld 408576698