Adding <keygen> Content Setting (Blink)

third_party/WebKit/Source/core/html/HTMLKeygenElement.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2010 Apple Inc. All rights reserved.
  *           (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 17 matching lines @@
 #include "bindings/core/v8/ExceptionStatePlaceholder.h"
 #include "core/HTMLNames.h"
 #include "core/dom/Document.h"
 #include "core/dom/Text.h"
 #include "core/dom/shadow/ShadowRoot.h"
 #include "core/frame/UseCounter.h"
 #include "core/html/FormData.h"
 #include "core/html/HTMLOptionElement.h"
 #include "core/html/HTMLSelectElement.h"
 #include "core/layout/LayoutBlockFlow.h"
+#include "core/loader/FrameLoaderClient.h"
 #include "platform/text/PlatformLocale.h"
 #include "public/platform/Platform.h"
 #include "public/platform/WebLocalizedString.h"
 #include "wtf/StdLibExtras.h"
 
 using namespace blink;
 
 namespace blink {
 
 using namespace HTMLNames;
 
 HTMLKeygenElement::HTMLKeygenElement(Document& document, HTMLFormElement* form)
     : HTMLFormControlElementWithState(keygenTag, document, form)
 {
     UseCounter::count(document, UseCounter::HTMLKeygenElement);
 }
 
 PassRefPtrWillBeRawPtr<HTMLKeygenElement> HTMLKeygenElement::create(Document& document, HTMLFormElement* form)
 {
     RefPtrWillBeRawPtr<HTMLKeygenElement> keygen = adoptRefWillBeNoop(new HTMLKeygenElement(document, form));
     keygen->ensureUserAgentShadowRoot();
     return keygen.release();
 }
 
 LayoutObject* HTMLKeygenElement::createLayoutObject(const ComputedStyle& style)
 {
+    if (!document().frame()->loader().client()->allowKeygen())
+        document().frame()->loader().client()->didNotAllowKeygen();

[jochen (gone - plz use gerrit), 2015/11/11 22:14:51]

ok, so this should not be a content setting like thing at all:

it's not a check whether we allow keygen, and the didNotAllowKeygen callback is
also lying about what it does.

instead, the HTMLKeygenElement ctor should just ping the embedder about the fact
that it's there.

[svaldez, 2015/11/23 20:13:50]

Done.

+
     // TODO(mstensho): While it's harmful and meaningless to allow most display types on replaced
     // content (e.g. table, table-row or flex), it would be useful to honor at least some of
     // them. Table-cell (and maybe table-caption too), for instance. See crbug.com/335040
     return new LayoutBlockFlow(this);
 }
 
 void HTMLKeygenElement::didAddUserAgentShadowRoot(ShadowRoot& root)
 {
     DEFINE_STATIC_LOCAL(AtomicString, keygenSelectPseudoId, ("-webkit-keygen-select", AtomicString::ConstructFromLiteral));
 
@@ skipping 55 matching lines @@
 {
     return true;
 }
 
 bool HTMLKeygenElement::supportsAutofocus() const
 {
     return true;
 }
 
 } // namespace