Adding <keygen> Content Setting (Blink)

content/browser/renderer_host/render_message_filter.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/render_message_filter.h"
 
 #include <map>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 562 matching lines @@
     case 1:
       key_size_in_bits = 1024;
       break;
     default:
       DCHECK(false) << "Illegal key_size_index " << key_size_index;
       RenderProcessHostMsg_Keygen::WriteReplyParams(reply_msg, std::string());
       Send(reply_msg);
       return;
   }
 
+  if (!GetContentClient()->browser()->AllowKeygen(url, resource_context_)) {

[Bernhard Bauer, 2015/11/05 11:12:13]

If you have this check anyway, why do you need the one in the renderer? Just
fail here and show the blockage icon.

[svaldez, 2015/11/05 16:35:20]

The problem is that we want to have the Page Action show up when the page is
rendered, instead of having UI show up when the form is being submitted.

[Bernhard Bauer, 2015/11/05 16:45:18]

Wait, so you want to show something in the omnibox anytime any webpage has a
<keygen> element, even if it's never used? Isn't that a bit overkill?

+    RenderProcessHostMsg_Keygen::WriteReplyParams(reply_msg, std::string());
+    Send(reply_msg);
+    return;
+  }
+
   resource_context_->CreateKeygenHandler(
       key_size_in_bits,
       challenge_string,
       url,
       base::Bind(
           &RenderMessageFilter::PostKeygenToWorkerThread, this, reply_msg));
 }
 
 void RenderMessageFilter::PostKeygenToWorkerThread(
     IPC::Message* reply_msg,
@@ skipping 95 matching lines @@
 void RenderMessageFilter::OnDeletedGpuMemoryBuffer(
     gfx::GpuMemoryBufferId id,
     uint32 sync_point) {
   DCHECK(BrowserGpuMemoryBufferManager::current());
 
   BrowserGpuMemoryBufferManager::current()->ChildProcessDeletedGpuMemoryBuffer(
       id, PeerHandle(), render_process_id_, sync_point);
 }
 
 }  // namespace content