Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 141703028: Remove input.type = ""; quirk. (Closed)

Created:
6 years, 10 months ago by sof
Modified:
6 years, 10 months ago
Reviewers:
tkent, keishi
CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove input.type = ""; quirk. Do not treat setting input.type to the empty string as a special case (i.e., as removing the attribute), just update the underlying attribute as for any other value. This aligns behavior with Gecko and Presto (and spec); Trident treats such as a no-op, which in any case was incompatible with the previous behavior here of removing the attribute. i.e., the test added passes for all but Trident. R=tkent@chromium.org BUG= TEST=fast/forms/input-type-change3 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166593

Patch Set 1 #

Total comments: 3

Patch Set 2 : Move tests to fast/dom/input-type-change3 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -28 lines) Patch
M LayoutTests/fast/forms/input-type-change3.html View 1 1 chunk +24 lines, -20 lines 0 comments Download
M LayoutTests/fast/forms/input-type-change3-expected.txt View 1 1 chunk +32 lines, -0 lines 0 comments Download
M Source/core/html/HTMLInputElement.cpp View 1 chunk +1 line, -8 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
sof
When you have a spare moment, please take a look.
6 years, 10 months ago (2014-02-05 14:38:00 UTC) #1
tkent
https://codereview.chromium.org/141703028/diff/1/LayoutTests/fast/dom/HTMLInputElement/input-type-attribute.html File LayoutTests/fast/dom/HTMLInputElement/input-type-attribute.html (right): https://codereview.chromium.org/141703028/diff/1/LayoutTests/fast/dom/HTMLInputElement/input-type-attribute.html#newcode1 LayoutTests/fast/dom/HTMLInputElement/input-type-attribute.html:1: <!DOCTYPE HTML> Please merge these tests to fast/forms/input-type-change3.html. We ...
6 years, 10 months ago (2014-02-05 23:58:18 UTC) #2
sof
The failures currently reported by the trybots appear unrelated; no regressions seen when testing locally. ...
6 years, 10 months ago (2014-02-06 08:27:15 UTC) #3
tkent
lgtm https://codereview.chromium.org/141703028/diff/1/LayoutTests/fast/dom/HTMLInputElement/input-type-attribute.html File LayoutTests/fast/dom/HTMLInputElement/input-type-attribute.html (right): https://codereview.chromium.org/141703028/diff/1/LayoutTests/fast/dom/HTMLInputElement/input-type-attribute.html#newcode1 LayoutTests/fast/dom/HTMLInputElement/input-type-attribute.html:1: <!DOCTYPE HTML> On 2014/02/06 08:27:15, sof wrote: > ...
6 years, 10 months ago (2014-02-06 08:29:38 UTC) #4
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 10 months ago (2014-02-06 08:57:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/141703028/80001
6 years, 10 months ago (2014-02-06 08:57:24 UTC) #6
commit-bot: I haz the power
6 years, 10 months ago (2014-02-06 10:15:37 UTC) #7
Message was sent while issue was closed. 
Change committed as 166593

Powered by Google App Engine
This is Rietveld 408576698