Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Unified Diff: pkg/polymer_expressions/lib/parser.dart

Issue 141703024: Refactor of PolymerExpressions. Adds "as" expressions. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: syntax, bindings, and globals tests now passing in Safari Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/polymer_expressions/lib/expression.dart ('k') | pkg/polymer_expressions/lib/polymer_expressions.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/polymer_expressions/lib/parser.dart
diff --git a/pkg/polymer_expressions/lib/parser.dart b/pkg/polymer_expressions/lib/parser.dart
index 411c7ae0be5c5827bdc0b566ef37bf2e1830f8f8..4d0de87b96f0047e60b935e99e48b93b7c24303b 100644
--- a/pkg/polymer_expressions/lib/parser.dart
+++ b/pkg/polymer_expressions/lib/parser.dart
@@ -64,8 +64,14 @@ class Parser {
_advance();
var right = _parseUnary();
left = _makeInvokeOrGetter(left, right);
- } else if (_token.kind == KEYWORD_TOKEN && _token.value == 'in') {
- left = _parseComprehension(left);
+ } else if (_token.kind == KEYWORD_TOKEN) {
+ if (_token.value == 'in') {
+ left = _parseInExpression(left);
+ } else if (_token.value == 'as') {
+ left = _parseAsExpression(left);
+ } else {
+ break;
+ }
} else if (_token.kind == OPERATOR_TOKEN
&& _token.precedence >= precedence) {
left = _token.value == '?' ? _parseTernary(left) : _parseBinary(left);
@@ -141,8 +147,8 @@ class Parser {
_advance();
// TODO(justin): return keyword node
return _astFactory.identifier('this');
- } else if (keyword == 'in') {
- return null;
+ } else if (KEYWORDS.contains(keyword)) {
+ throw new ParseException('invalid keyword: $keyword');
}
throw new ArgumentError('unrecognized keyword: $keyword');
case IDENTIFIER_TOKEN:
@@ -204,7 +210,7 @@ class Parser {
return _astFactory.mapLiteralEntry(key, value);
}
- InExpression _parseComprehension(Expression left) {
+ InExpression _parseInExpression(Expression left) {
assert(_token.value == 'in');
if (left is! Identifier) {
throw new ParseException(
@@ -215,6 +221,17 @@ class Parser {
return _astFactory.inExpr(left, right);
}
+ AsExpression _parseAsExpression(Expression left) {
+ assert(_token.value == 'as');
+ _advance();
+ var right = _parseExpression();
+ if (right is! Identifier) {
+ throw new ParseException(
+ "as... statements must end with an identifier");
+ }
+ return _astFactory.asExpr(left, right);
+ }
+
Expression _parseInvokeOrIdentifier() {
if (_token.value == 'true') {
_advance();
« no previous file with comments | « pkg/polymer_expressions/lib/expression.dart ('k') | pkg/polymer_expressions/lib/polymer_expressions.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698