pkg/polymer_expressions/lib/tokenizer.dart - Issue 141703024: Refactor of PolymerExpressions. Adds "as" expressions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/polymer_expressions/lib/tokenizer.dart

Issue 141703024: Refactor of PolymerExpressions. Adds "as" expressions. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address review comments Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/polymer_expressions/lib/polymer_expressions.dart ('K') | « pkg/polymer_expressions/lib/polymer_expressions.dart ('k') | pkg/polymer_expressions/lib/visitor.dart » ('j') | pkg/polymer_expressions/pubspec.yaml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/polymer_expressions/lib/tokenizer.dart

diff --git a/pkg/polymer_expressions/lib/tokenizer.dart b/pkg/polymer_expressions/lib/tokenizer.dart

index fb660877d2849b49b395d217cd7179540083f25a..d63f2b4ec829430d35eb5eea92613313451366cb 100644

--- a/pkg/polymer_expressions/lib/tokenizer.dart

+++ b/pkg/polymer_expressions/lib/tokenizer.dart

@@ -59,7 +59,7 @@ const _GROUPERS = const [_OPEN_PAREN, _CLOSE_PAREN,

const _TWO_CHAR_OPS = const ['==', '!=', '<=', '>=', '||', '&&'];

-const _KEYWORDS = const ['in', 'this'];

+const KEYWORDS = const ['as', 'in', 'this'];

const _PRECEDENCE = const {

'!': 0,

@@ -218,7 +218,7 @@ class Tokenizer {

_advance();

}

var value = _sb.toString();

- if (_KEYWORDS.contains(value)) {

+ if (KEYWORDS.contains(value)) {

_tokens.add(new Token(KEYWORD_TOKEN, value));

} else {

_tokens.add(new Token(IDENTIFIER_TOKEN, value));