Issue 141703017: Fix FIXME in findPreviousAndNextAttributes in RenderSVGText.cpp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 141703017: Fix FIXME in findPreviousAndNextAttributes in RenderSVGText.cpp (Closed)

Created:
6 years, 10 months ago by fs

Modified:
6 years, 10 months ago

Reviewers:
pdr., f(malita), Stephen Chennney

CC:
blink-reviews, krit, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, pdr, Stephen Chennney, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Fix FIXME in findPreviousAndNextAttributes in RenderSVGText.cpp Use the existing pre-order traversal methods on RenderObject to implement the traversal in an iterative fashion instead of as a recursion. This allows moving the |stopAfterNext| boolean to the scope of findPreviousAndNextAttributes, so do that and fix up the callers. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165950

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -19 lines)			Patch
	M	Source/core/rendering/svg/RenderSVGText.cpp	View		4 chunks	+17 lines, -19 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/141703017/1

6 years, 10 months ago (2014-01-28 17:43:37 UTC) #3

Message was sent while issue was closed.

Change committed as 165950

Expand Messages | Collapse Messages