Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1194)

Issue 141703005: Remove all exclude rules that filename_rules.gypi already handles. (Closed)

Created:
6 years, 11 months ago by dshwang
Modified:
6 years, 11 months ago
CC:
chromium-reviews, kalyank, erikwright+watch_chromium.org, sadrul, ben+ash_chromium.org, darin-cc_chromium.org
Base URL:
https://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Remove all exclude rules that filename_rules.gypi already handles. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245910

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -42 lines) Patch
M ash/ash.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M base/base.gyp View 1 chunk +0 lines, -6 lines 0 comments Download
M base/base.gypi View 3 chunks +0 lines, -18 lines 0 comments Download
M printing/printing.gyp View 1 chunk +1 line, -7 lines 0 comments Download
M ui/ui.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
M webkit/common/webkit_common.gyp View 1 chunk +2 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dshwang
6 years, 11 months ago (2014-01-17 19:01:45 UTC) #1
jochen (gone - plz use gerrit)
removing myself as I own none of these files
6 years, 11 months ago (2014-01-19 19:02:37 UTC) #2
darin (slow to review)
LGTM
6 years, 11 months ago (2014-01-20 05:26:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/141703005/1
6 years, 11 months ago (2014-01-20 12:30:59 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-20 14:34:46 UTC) #5
Message was sent while issue was closed.
Change committed as 245910

Powered by Google App Engine
This is Rietveld 408576698