Whitelist extensions from EXTERNAL_COMPONENT for public sessions

Whitelist extensions from EXTERNAL_COMPONENT for public sessions

Extensions whose install location is EXTERNAL_COMPONENT are components of
Chrome itself and should be allowed in public sessions as well.

BUG=332512
TEST=Updated unit tests; manual

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246868

[bartfab (slow), 2014-01-17 17:57:37]

Hi Antony,

Could you please review?

Dmitry, FYI.

[bartfab (slow), 2014-01-22 11:02:18]

Hi Antony,

Friendly review ping.

[asargent_no_longer_on_chrome, 2014-01-23 18:53:34]

Sorry for review latency. 

lgtm w/ one question for you to double-check

https://codereview.chromium.org/141703003/diff/1/chrome/browser/chromeos/exte...
File
chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc
(left):

https://codereview.chromium.org/141703003/diff/1/chrome/browser/chromeos/exte...
chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc:111:
}
Just to double-check, it looks like this CL changes things so that hosted apps
and kDeviceLocalAccountWhitelist members now are only allowed for
TYPE_PUBLIC_SESSION account types, whereas before they were allowed for any
account whose type != TYPE_KIOSK_APP. Was that what you intended?

[bartfab (slow), 2014-01-24 10:06:19]

https://codereview.chromium.org/141703003/diff/1/chrome/browser/chromeos/exte...
File
chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc
(left):

https://codereview.chromium.org/141703003/diff/1/chrome/browser/chromeos/exte...
chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc:111:
}
On 2014/01/23 18:53:35, Antony Sargent wrote:
> Just to double-check, it looks like this CL changes things so that hosted apps
> and kDeviceLocalAccountWhitelist members now are only allowed for
> TYPE_PUBLIC_SESSION account types, whereas before they were allowed for any
> account whose type != TYPE_KIOSK_APP. Was that what you intended?

Yes, this was intentional. There is actually no functional change here. The new
code just makes it more explicit what is going on. Right now,
TYPE_PUBLIC_SESSION and TYPE_KIOSK_APP are the only types of device-local
accounts that exist. If in the future we add a new TYPE_X, I do not want it to
implictly inherit the behavior of TYPE_PUBLIC_SESSION. Instead, *all*
apps/extensions will be blocked for TYPE_X until we make an explicit decision
what should be allowed and add it to the code here.

[commit-bot: I haz the power, 2014-01-24 10:07:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bartfab@chromium.org/141703003/1

[commit-bot: I haz the power, 2014-01-24 12:17:58]

Retried try job too often on win_rel for step(s) telemetry_perf_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2014-01-24 12:26:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bartfab@chromium.org/141703003/1

[commit-bot: I haz the power, 2014-01-24 13:17:26]

Change committed as 246868