chrome/browser/ui/content_settings/content_setting_bubble_model.cc - Issue 1417023007: Replace HostContentSettingsMap::AddExceptionForURL with SetNarrowestWebsiteSetting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/content_settings/content_setting_bubble_model.cc

Issue 1417023007: Replace HostContentSettingsMap::AddExceptionForURL with SetNarrowestWebsiteSetting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/android/content_settings/popup_blocked_infobar_delegate.cc ('k') | chrome/browser/ui/website_settings/website_settings.cc » ('j') | components/content_settings/core/browser/host_content_settings_map.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/content_settings/content_setting_bubble_model.cc

diff --git a/chrome/browser/ui/content_settings/content_setting_bubble_model.cc b/chrome/browser/ui/content_settings/content_setting_bubble_model.cc

index 76351bd18260d8b26f21e23fefa360ad9285ec6b..343aa88944495280ced116dc31e8719d8f9c908b 100644

--- a/chrome/browser/ui/content_settings/content_setting_bubble_model.cc

+++ b/chrome/browser/ui/content_settings/content_setting_bubble_model.cc

@@ -416,11 +416,10 @@ void ContentSettingSingleRadioGroup::SetRadioGroup() {

void ContentSettingSingleRadioGroup::AddException(ContentSetting setting) {

msw 2015/11/09 18:41:56 nit: rename AddException to match SetNarrowestCont

raymes 2015/11/09 23:29:02 Done.

if (profile()) {

- HostContentSettingsMapFactory::GetForProfile(profile())->AddExceptionForURL(

- bubble_content().radio_group.url,

- content_type(),

- setting);

+ HostContentSettingsMapFactory::GetForProfile(profile())

+ ->SetNarrowestContentSetting(bubble_content().radio_group.url,

+ bubble_content().radio_group.url,

+ content_type(), setting);

}