third_party/WebKit/Source/core/frame/DOMWindow.h - Issue 1417023006: bindings: Refactors BindingSecurity::shouldAllowAccessToXXX.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/DOMWindow.h

Issue 1417023006: bindings: Refactors BindingSecurity::shouldAllowAccessToXXX. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed the assertion condition. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/frame/DOMWindow.h

diff --git a/third_party/WebKit/Source/core/frame/DOMWindow.h b/third_party/WebKit/Source/core/frame/DOMWindow.h

index f8bedc427a4b9520698f61e86554c7496bf4159b..7c2a6e4c314b1561cef0da2fa35a9ccbe447ade0 100644

--- a/third_party/WebKit/Source/core/frame/DOMWindow.h

+++ b/third_party/WebKit/Source/core/frame/DOMWindow.h

@@ -184,8 +184,8 @@ public:

void postMessage(PassRefPtr<SerializedScriptValue> message, const MessagePortArray*, const String& targetOrigin, LocalDOMWindow* source, ExceptionState&);

- String sanitizedCrossDomainAccessErrorMessage(LocalDOMWindow* callingWindow);

- String crossDomainAccessErrorMessage(LocalDOMWindow* callingWindow);

+ String sanitizedCrossDomainAccessErrorMessage(const LocalDOMWindow* callingWindow) const;

+ String crossDomainAccessErrorMessage(const LocalDOMWindow* callingWindow) const;

bool isInsecureScriptAccess(LocalDOMWindow& callingWindow, const String& urlString);

// FIXME: When this DOMWindow is no longer the active DOMWindow (i.e.,

« no previous file with comments | « third_party/WebKit/Source/core/events/EventTarget.cpp ('k') | third_party/WebKit/Source/core/frame/DOMWindow.cpp » ('j') | no next file with comments »