Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 1417023005: [turbofan] Simplify representation inference for add/subtract. (Closed)

Created:
5 years, 1 month ago by Jarin
Modified:
5 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Simplify representation inference for add/subtract. We don't really care about signedness when truncating to Word32. Committed: https://crrev.com/b881465d7c913a771dffa1a9731fb4e0193a6693 Cr-Commit-Position: refs/heads/master@{#31779}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -29 lines) Patch
M src/compiler/simplified-lowering.cc View 3 chunks +10 lines, -29 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Jarin
Could you take a look, please? Tests passed on my machine, so it must be ...
5 years, 1 month ago (2015-11-04 10:40:17 UTC) #3
Benedikt Meurer
lgtm
5 years, 1 month ago (2015-11-04 10:42:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417023005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417023005/1
5 years, 1 month ago (2015-11-04 10:47:12 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-04 10:53:38 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-04 10:54:04 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b881465d7c913a771dffa1a9731fb4e0193a6693
Cr-Commit-Position: refs/heads/master@{#31779}

Powered by Google App Engine
This is Rietveld 408576698