Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1417013011: Report iOS as iOS rather than OS X. (Closed)

Created:
5 years, 1 month ago by rmacnak
Modified:
5 years, 1 month ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 1

Patch Set 3 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M CHANGELOG.md View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/bin/platform_macos.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/vm/os_macos.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M sdk/lib/io/platform.dart View 1 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
rmacnak
5 years, 1 month ago (2015-10-29 21:20:39 UTC) #2
Ivan Posva
https://codereview.chromium.org/1417013011/diff/1/sdk/lib/io/platform.dart File sdk/lib/io/platform.dart (right): https://codereview.chromium.org/1417013011/diff/1/sdk/lib/io/platform.dart#newcode120 sdk/lib/io/platform.dart:120: static final bool isIOS = (_operatingSystem == "ios"); How ...
5 years, 1 month ago (2015-10-29 21:49:44 UTC) #3
rmacnak
https://codereview.chromium.org/1417013011/diff/1/sdk/lib/io/platform.dart File sdk/lib/io/platform.dart (right): https://codereview.chromium.org/1417013011/diff/1/sdk/lib/io/platform.dart#newcode120 sdk/lib/io/platform.dart:120: static final bool isIOS = (_operatingSystem == "ios"); On ...
5 years, 1 month ago (2015-10-30 17:31:20 UTC) #4
rmacnak
https://codereview.chromium.org/1417013011/diff/20001/sdk/lib/io/platform.dart File sdk/lib/io/platform.dart (right): https://codereview.chromium.org/1417013011/diff/20001/sdk/lib/io/platform.dart#newcode120 sdk/lib/io/platform.dart:120: static final bool isiOS = (_operatingSystem == "ios"); Not ...
5 years, 1 month ago (2015-11-13 18:56:09 UTC) #5
Ivan Posva
LGTM -ip
5 years, 1 month ago (2015-11-13 18:57:02 UTC) #6
rmacnak
5 years, 1 month ago (2015-11-13 19:15:09 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
f3759dedd312febf638cd0d46b71a7a049eeac4a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698