Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 1417013007: Revert of Canonicalize handles for optimized compilation. (Closed)

Created:
5 years, 1 month ago by Yang
Modified:
5 years, 1 month ago
CC:
Paweł Hajdan Jr., v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Canonicalize handles for optimized compilation. (patchset #1 id:1 of https://codereview.chromium.org/1423833003/ ) Reason for revert: GC stress failure on ia32 optdebug: /tmp/runfswAKT/out/Debug/d8 --test --random-seed=-1536184370 --turbo --always-opt --nohard-abort --nodead-code-elimination --nofold-constants --enable-slow-asserts --debug-code --verify-heap --stack-size=46 /tmp/runfswAKT/test/mjsunit/mjsunit.js /tmp/runfswAKT/test/mjsunit/regress/regress-1132.js --gc-interval=500 --stress-compaction --concurrent-recompilation-queue-length=64 --concurrent-recompilation-delay=500 --concurrent-recompilation Run #1 Exit code: -6 Result: FAIL Expected outcomes: PASS Duration: 00:06:279 Stderr: # # Fatal error in ../../src/hashmap.h, line 248 # Check failed: base::bits::IsPowerOfTwo32(capacity_). # ==== C stack trace =============================== Original issue's description: > Canonicalize handles for optimized compilation. > > R=bmeurer@chromium.org > > Committed: https://crrev.com/15f36b2b1e166a511966a9991fddea94f890a755 > Cr-Commit-Position: refs/heads/master@{#31566} TBR=jochen@chromium.org,bmeurer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/8bcef0d73d4532ae959392df88c77789e28808bb Cr-Commit-Position: refs/heads/master@{#31570}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -243 lines) Patch
M include/v8.h View 1 chunk +1 line, -1 line 0 comments Download
M src/allocation-site-scopes.h View 1 chunk +1 line, -1 line 0 comments Download
M src/api.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler.cc View 3 chunks +2 lines, -7 lines 0 comments Download
M src/handles.h View 6 chunks +5 lines, -47 lines 0 comments Download
M src/handles.cc View 3 chunks +1 line, -45 lines 0 comments Download
M src/handles-inl.h View 5 chunks +20 lines, -34 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/identity-map.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/json-stringifier.h View 2 chunks +2 lines, -3 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/string-builder.h View 1 chunk +2 lines, -4 lines 0 comments Download
M src/string-builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x87/macro-assembler-x87.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-identity-map.cc View 1 chunk +0 lines, -80 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
Created Revert of Canonicalize handles for optimized compilation.
5 years, 1 month ago (2015-10-26 14:44:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417013007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417013007/1
5 years, 1 month ago (2015-10-26 14:44:57 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-26 14:45:21 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-10-26 14:45:43 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8bcef0d73d4532ae959392df88c77789e28808bb
Cr-Commit-Position: refs/heads/master@{#31570}

Powered by Google App Engine
This is Rietveld 408576698