Chromium Code Reviews

Issue 1417003005: Subzero: Add "szbuild.py --no-sz" arg for suppressing the pnacl-sz run. (Closed)

Created:
5 years, 1 month ago by Jim Stichnoth
Modified:
5 years, 1 month ago
Reviewers:
Karl, sehr, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Add "szbuild.py --no-sz" arg for suppressing the pnacl-sz run. This enables the following workflow: 1. Run "szbuild.py --filetype=asm ..." to generate a .s file. 2. Edit the .s file to mock up a Subzero change. 3. Run "szbuild.py --filetype=asm --no-sz ..." to restart the build post pnacl-sz. This workflow is good for trying out localized changes to hot basic blocks, though it isn't really appropriate for global optimizations like register allocation. BUG= none R=kschimpf@google.com Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=42356fb7a19e5fe9c42a90851dc76f0a7f795d31

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+20 lines, -16 lines)
M pydir/szbuild.py View 2 chunks +20 lines, -16 lines 0 comments

Messages

Total messages: 5 (2 generated)
Jim Stichnoth
5 years, 1 month ago (2015-11-10 01:29:18 UTC) #3
Karl
lgtm
5 years, 1 month ago (2015-11-10 16:34:20 UTC) #4
Jim Stichnoth
5 years, 1 month ago (2015-11-10 16:41:18 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
42356fb7a19e5fe9c42a90851dc76f0a7f795d31 (presubmit successful).

Powered by Google App Engine