content/browser/browser_main_loop.cc - Issue 1417003003: [tracing] Dump child processes' memory metrics in browser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/browser_main_loop.cc

Issue 1417003003: [tracing] Dump child processes' memory metrics in browser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@web_cache2_base

Patch Set: Adding comment instead of notreached. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/tracing/process_metrics_memory_dump_provider_unittest.cc ('k') | content/browser/tracing/tracing_controller_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/browser_main_loop.cc

diff --git a/content/browser/browser_main_loop.cc b/content/browser/browser_main_loop.cc

index 732f0e257348f4ac8621dd4bfe2c5b75c3bb59f5..a59071d82990729a7ff696d17ddaea931a1098a1 100644

--- a/content/browser/browser_main_loop.cc

+++ b/content/browser/browser_main_loop.cc

@@ -32,6 +32,7 @@

#include "base/trace_event/memory_dump_manager.h"

#include "base/trace_event/trace_event.h"

#include "build/build_config.h"

+#include "components/tracing/process_metrics_memory_dump_provider.h"

#include "components/tracing/trace_config_file.h"

#include "components/tracing/trace_to_console.h"

#include "components/tracing/tracing_switches.h"

@@ -690,6 +691,8 @@ void BrowserMainLoop::PostMainMessageLoopStart() {

// Enable memory-infra dump providers.

InitSkiaEventTracer();

+ tracing::ProcessMetricsMemoryDumpProvider::RegisterForProcess(

+ base::kNullProcessId);

base::trace_event::MemoryDumpManager::GetInstance()->RegisterDumpProvider(

HostSharedBitmapManager::current(), "HostSharedBitmapManager", nullptr);

base::trace_event::MemoryDumpManager::GetInstance()->RegisterDumpProvider(