[tracing] Dump child processes' memory metrics in browser

base/trace_event/process_memory_maps_dump_provider.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_TRACE_EVENT_PROCESS_MEMORY_MAPS_DUMP_PROVIDER_H_
 #define BASE_TRACE_EVENT_PROCESS_MEMORY_MAPS_DUMP_PROVIDER_H_
 
 #include "base/gtest_prod_util.h"
 #include "base/memory/singleton.h"
 #include "base/trace_event/memory_dump_provider.h"
 
 namespace base {
 namespace trace_event {
 
 // Dump provider which collects process-wide memory stats.
 class BASE_EXPORT ProcessMemoryMapsDumpProvider : public MemoryDumpProvider {
  public:
-  static ProcessMemoryMapsDumpProvider* GetInstance();
+  // Creates a dump provider for a child process with |process_id|.
+  // Note: Current Process should be able to access process metrics of the
+  // process, else this method returns empty ptr.
+  static scoped_ptr<ProcessMemoryMapsDumpProvider> CreateForProcess(

[Primiano Tucci (use gerrit), 2015/11/03 15:14:08]

this cannot be a singleton and a non-singleton at the same time.
de-singletonify?

+      ProcessHandle process);
+
+  ~ProcessMemoryMapsDumpProvider() override;
 
   // MemoryDumpProvider implementation.
   bool OnMemoryDump(const MemoryDumpArgs& args,
                     ProcessMemoryDump* pmd) override;
 
  private:
   friend struct DefaultSingletonTraits<ProcessMemoryMapsDumpProvider>;
   FRIEND_TEST_ALL_PREFIXES(ProcessMemoryMapsDumpProviderTest, ParseProcSmaps);
 
 #if defined(OS_LINUX) || defined(OS_ANDROID) || defined(OS_NACL)
   static FILE* proc_smaps_for_testing;
 #endif
 
-  ProcessMemoryMapsDumpProvider();
-  ~ProcessMemoryMapsDumpProvider() override;
+  ProcessMemoryMapsDumpProvider(ProcessHandle process);
+
+  ProcessHandle process_;
 
   DISALLOW_COPY_AND_ASSIGN(ProcessMemoryMapsDumpProvider);
 };
 
 }  // namespace trace_event
 }  // namespace base
 
 #endif  // BASE_TRACE_EVENT_PROCESS_MEMORY_MAPS_DUMP_PROVIDER_H_