[tracing] Dump child processes' memory metrics in browser

content/browser/tracing/tracing_controller_impl.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 #include "content/browser/tracing/tracing_controller_impl.h"
 
 #include "base/bind.h"
 #include "base/files/file_util.h"
 #include "base/json/string_escape.h"
 #include "base/macros.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/trace_event/trace_event.h"
+#include "components/tracing/process_metrics_memory_dump_manager.h"
 #include "content/browser/tracing/file_tracing_provider_impl.h"
 #include "content/browser/tracing/power_tracing_agent.h"
 #include "content/browser/tracing/trace_message_filter.h"
 #include "content/browser/tracing/tracing_ui.h"
 #include "content/common/child_process_messages.h"
 #include "content/public/browser/browser_message_filter.h"
 #include "content/public/common/child_process_host.h"
 #include "content/public/common/content_switches.h"
 
 #if defined(OS_CHROMEOS)
@@ skipping 460 matching lines @@
 void TracingControllerImpl::AddTraceMessageFilter(
     TraceMessageFilter* trace_message_filter) {
   if (!BrowserThread::CurrentlyOn(BrowserThread::UI)) {
     BrowserThread::PostTask(BrowserThread::UI, FROM_HERE,
         base::Bind(&TracingControllerImpl::AddTraceMessageFilter,
                    base::Unretained(this),
                    make_scoped_refptr(trace_message_filter)));
     return;
   }
 
+  tracing::ProcessMetricsMemoryDumpManager::GetInstance()->RegisterForProcess(
+      trace_message_filter->peer_pid());

[Primiano Tucci (use gerrit), 2015/11/17 10:44:13]

Shouldn't this be >PeerHandle() ?

[ssid, 2015/11/17 13:55:06]

Done.

+
   trace_message_filters_.insert(trace_message_filter);
   if (can_cancel_watch_event()) {
     trace_message_filter->SendSetWatchEvent(watch_category_name_,
                                             watch_event_name_);
   }
   if (can_disable_recording()) {
     trace_message_filter->SendBeginTracing(
         TraceLog::GetInstance()->GetCurrentTraceConfig());
   }
   if (can_disable_monitoring()) {
     trace_message_filter->SendEnableMonitoring(
         TraceLog::GetInstance()->GetCurrentTraceConfig());
   }
 
   FOR_EACH_OBSERVER(TraceMessageFilterObserver, trace_message_filter_observers_,
                     OnTraceMessageFilterAdded(trace_message_filter));
 }
 
 void TracingControllerImpl::RemoveTraceMessageFilter(
     TraceMessageFilter* trace_message_filter) {
   if (!BrowserThread::CurrentlyOn(BrowserThread::UI)) {
     BrowserThread::PostTask(BrowserThread::UI, FROM_HERE,
         base::Bind(&TracingControllerImpl::RemoveTraceMessageFilter,
                    base::Unretained(this),
                    make_scoped_refptr(trace_message_filter)));
     return;
   }
 
+  tracing::ProcessMetricsMemoryDumpManager::GetInstance()->UnregisterForProcess(
+      trace_message_filter->peer_pid());

[Primiano Tucci (use gerrit), 2015/11/17 10:44:12]

ditto

[ssid, 2015/11/17 13:55:06]

Done.

+
   // If a filter is removed while a response from that filter is pending then
   // simulate the response. Otherwise the response count will be wrong and the
   // completion callback will never be executed.
   if (pending_disable_recording_ack_count_ > 0) {
     TraceMessageFilterSet::const_iterator it =
         pending_disable_recording_filters_.find(trace_message_filter);
     if (it != pending_disable_recording_filters_.end()) {
       BrowserThread::PostTask(BrowserThread::UI, FROM_HERE,
           base::Bind(&TracingControllerImpl::OnDisableRecordingAcked,
                      base::Unretained(this),
@@ skipping 412 matching lines @@
   is_monitoring_ = is_monitoring;
 #if !defined(OS_ANDROID)
   for (std::set<TracingUI*>::iterator it = tracing_uis_.begin();
        it != tracing_uis_.end(); it++) {
     (*it)->OnMonitoringStateChanged(is_monitoring);
   }
 #endif
 }
 
 }  // namespace content