Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1416973015:
[Ozone-DRM] Simplify CrtcController::SignalPageFlipRequest (Closed)
|
Created:
5 years, 1 month ago by dnicoara Modified:
5 years, 1 month ago Reviewers:
spang CC:
chromium-reviews, kalyank, piman+watch_chromium.org, ozone-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[Ozone-DRM] Simplify CrtcController::SignalPageFlipRequest
SignalPageFlipRequest should only be called when a page
flip request was scheduled, so move the check in the dtor
since that's the only place it is needed.
BUG=none
Committed: https://crrev.com/c2f566442007a520ad237b5890a74d75aab6e378
Cr-Commit-Position: refs/heads/master@{#357199}
Patch Set 1 #Patch Set 2 : . #
Dependent Patchsets: Messages
Total messages: 19 (9 generated)
dnicoara@chromium.org changed reviewers: + spang@chromium.org
PTAL
The CQ bit was checked by dnicoara@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1416973015/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1416973015/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2015/10/30 15:59:51, commit-bot: I haz the power wrote: > Dry run: This issue passed the CQ dry run. I guess the description needs update per https://codereview.chromium.org/1418503012/#msg10
Description was changed from ========== [Ozone-DRM] Remove re-entrancy support in page flip signaling All page flip requests should contain a task which will avoid re-entrancy, thus there is no reason to support re-entrancy. BUG=none ========== to ========== [Ozone-DRM] Simplify CrtcController::SignalPageFlipRequest All page flip requests should contain a task which will avoid re-entrancy, thus there is no reason to support re-entrancy. Also SignalPageFlipRequest should only be called when a page flip request was scheduled, so move the check in the dtor since that's the only place it is needed. BUG=none ==========
On 2015/10/30 20:30:03, spang wrote: > On 2015/10/30 15:59:51, commit-bot: I haz the power wrote: > > Dry run: This issue passed the CQ dry run. > > I guess the description needs update per > https://codereview.chromium.org/1418503012/#msg10 Added more details in the commit message.
On 2015/10/30 20:46:51, dnicoara wrote: > On 2015/10/30 20:30:03, spang wrote: > > On 2015/10/30 15:59:51, commit-bot: I haz the power wrote: > > > Dry run: This issue passed the CQ dry run. > > > > I guess the description needs update per > > https://codereview.chromium.org/1418503012/#msg10 > > Added more details in the commit message. Oh, I get why you put that in the message now. I actually think we should leave the scoped_refptr<> my_refptr = our_refptr_ It's a good safety practice even if not currently necessary. I was only confused by the if (!page_flip_) bits that are now moved to dtor.
lgtm
Description was changed from ========== [Ozone-DRM] Simplify CrtcController::SignalPageFlipRequest All page flip requests should contain a task which will avoid re-entrancy, thus there is no reason to support re-entrancy. Also SignalPageFlipRequest should only be called when a page flip request was scheduled, so move the check in the dtor since that's the only place it is needed. BUG=none ========== to ========== [Ozone-DRM] Simplify CrtcController::SignalPageFlipRequest Also SignalPageFlipRequest should only be called when a page flip request was scheduled, so move the check in the dtor since that's the only place it is needed. BUG=none ==========
The CQ bit was checked by dnicoara@chromium.org
The CQ bit was unchecked by dnicoara@chromium.org
Description was changed from ========== [Ozone-DRM] Simplify CrtcController::SignalPageFlipRequest Also SignalPageFlipRequest should only be called when a page flip request was scheduled, so move the check in the dtor since that's the only place it is needed. BUG=none ========== to ========== [Ozone-DRM] Simplify CrtcController::SignalPageFlipRequest SignalPageFlipRequest should only be called when a page flip request was scheduled, so move the check in the dtor since that's the only place it is needed. BUG=none ==========
The CQ bit was checked by dnicoara@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1416973015/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1416973015/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/c2f566442007a520ad237b5890a74d75aab6e378 Cr-Commit-Position: refs/heads/master@{#357199} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
