Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 1416973014: [turbofan] Move PropertyAccessInfo and friends to a separate file. (Closed)

Created:
5 years, 1 month ago by Benedikt Meurer
Modified:
5 years, 1 month ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Move PropertyAccessInfo and friends to a separate file. Also changed the way that transitioning stores are represented in a PropertyAccessInfo: There's no dedicated kind, but DataFields have an optional transition map. R=jarin@chromium.org BUG=v8:4470 LOG=n Committed: https://crrev.com/06eb555fa31c369a100414a30d6db0c7fa084989 Cr-Commit-Position: refs/heads/master@{#31692}

Patch Set 1 #

Patch Set 2 : Add missing factory() method. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+454 lines, -337 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/js-native-context-specialization.h View 4 chunks +5 lines, -9 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 10 chunks +19 lines, -328 lines 0 comments Download
A src/compiler/property-access-info.h View 1 chunk +113 lines, -0 lines 0 comments Download
A src/compiler/property-access-info.cc View 1 1 chunk +313 lines, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
5 years, 1 month ago (2015-10-30 12:59:26 UTC) #1
Benedikt Meurer
Hey Jaro, As requested, PropertyAccessInfo and the factory methods are now in a separate file. ...
5 years, 1 month ago (2015-10-30 13:00:17 UTC) #2
Jarin
lgtm
5 years, 1 month ago (2015-10-30 13:02:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1416973014/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1416973014/20001
5 years, 1 month ago (2015-10-30 13:02:42 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-10-30 14:24:51 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 14:25:33 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/06eb555fa31c369a100414a30d6db0c7fa084989
Cr-Commit-Position: refs/heads/master@{#31692}

Powered by Google App Engine
This is Rietveld 408576698