Abandon startup profiling for first WebContents when it gets hidden or navigated to a different ...

Abandon startup profiling for first WebContents when it gets hidden or navigated to a different page.

Also add histograms to track when startup profiling is abandonned (useful long term and also allows to
see the short term impact of this change).

BUG=525209
Committed: https://crrev.com/16bb3e51197639ac628b3f802f775bc83f437845
Cr-Commit-Position: refs/heads/master@{#355159}

[gab, 2015-10-20 19:27:06]

gab@chromium.org changed reviewers:
+ rkaplow@chromium.org

[gab, 2015-10-20 19:27:07]

Robert PTAL.

Thanks,
Gab

[rkaplow, 2015-10-20 20:08:30]

lgtm

Also it took me multiple reads of your CL description to see what you meant, I
was parsing it as "stop the profiling stats", not add stats for "stopping
profiling". Maybe reword description?

https://codereview.chromium.org/1416963002/diff/20001/chrome/browser/metrics/...
File chrome/browser/metrics/first_web_contents_profiler.cc (right):

https://codereview.chromium.org/1416963002/diff/20001/chrome/browser/metrics/...
chrome/browser/metrics/first_web_contents_profiler.cc:188: // Stop profiling on
any navigation to a different page as it (1) is no longer
text seems good but I would break this is up, a lot to parse for one sentance

https://codereview.chromium.org/1416963002/diff/20001/chrome/browser/metrics/...
File chrome/browser/metrics/first_web_contents_profiler.h (right):

https://codereview.chromium.org/1416963002/diff/20001/chrome/browser/metrics/...
chrome/browser/metrics/first_web_contents_profiler.h:51: COUNT
usually I see this as something like ENUM_MAX which is a bit more obvious but
not a big deal

[gab, 2015-10-20 20:11:06]

Description was changed from

==========
Stop profiling startup stats for first WebContents when it gets hidden or
navigated to a different page.

Also add histograms to track when startup profiling is abandonned (useful long
term and also allows to
see the short term impact of this change).

BUG=525209
==========

to

==========
Abandon startup profiling for first WebContents when it gets hidden or navigated
to a different page.

Also add histograms to track when startup profiling is abandonned (useful long
term and also allows to
see the short term impact of this change).

BUG=525209
==========

[gab, 2015-10-20 20:16:21]

Thanks, done (and rephrased desc to use "abandon" instead of "stop").

https://codereview.chromium.org/1416963002/diff/20001/chrome/browser/metrics/...
File chrome/browser/metrics/first_web_contents_profiler.cc (right):

https://codereview.chromium.org/1416963002/diff/20001/chrome/browser/metrics/...
chrome/browser/metrics/first_web_contents_profiler.cc:188: // Stop profiling on
any navigation to a different page as it (1) is no longer
On 2015/10/20 20:08:30, rkaplow wrote:
> text seems good but I would break this is up, a lot to parse for one sentance

Kept sentence, but re-ordered in bullet points, WDYT?

https://codereview.chromium.org/1416963002/diff/20001/chrome/browser/metrics/...
File chrome/browser/metrics/first_web_contents_profiler.h (right):

https://codereview.chromium.org/1416963002/diff/20001/chrome/browser/metrics/...
chrome/browser/metrics/first_web_contents_profiler.h:51: COUNT
On 2015/10/20 20:08:30, rkaplow wrote:
> usually I see this as something like ENUM_MAX which is a bit more obvious but
> not a big deal

Done.

[gab, 2015-10-20 20:16:34]

The CQ bit was checked by gab@chromium.org

[gab, 2015-10-20 20:16:34]

The patchset sent to the CQ was uploaded after l-g-t-m from rkaplow@chromium.org
Link to the patchset: https://codereview.chromium.org/1416963002/#ps40001
(title: "review:rkaplow")

[commit-bot: I haz the power, 2015-10-20 20:17:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1416963002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1416963002/40001

[commit-bot: I haz the power, 2015-10-20 21:38:39]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-10-20 21:39:22]

Patchset 3 (id:??) landed as
https://crrev.com/16bb3e51197639ac628b3f802f775bc83f437845
Cr-Commit-Position: refs/heads/master@{#355159}