content/browser/frame_host/navigation_request.h - Issue 1416953007: Add a function to add extra headers from NavigationThrottle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_request.h

Issue 1416953007: Add a function to add extra headers from NavigationThrottle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@data-reduction-proxy-resource-throttle

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/navigation_handle_impl.h ('K') | « content/browser/frame_host/navigation_handle_impl_unittest.cc ('k') | content/browser/frame_host/navigation_request.cc » ('j') | content/browser/frame_host/navigation_request.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/navigation_request.h

diff --git a/content/browser/frame_host/navigation_request.h b/content/browser/frame_host/navigation_request.h

index 294d086ce677a3f8817dd8ec3b4643e594a10944..b339f550845fb408ebe274484e4987c31dfecd93 100644

--- a/content/browser/frame_host/navigation_request.h

+++ b/content/browser/frame_host/navigation_request.h

@@ -159,8 +159,14 @@ class CONTENT_EXPORT NavigationRequest : public NavigationURLLoaderDelegate {

// Called when the NavigationThrottles have been checked by the

// NavigationHandle.

- void OnStartChecksComplete(NavigationThrottle::ThrottleCheckResult result);

- void OnRedirectChecksComplete(NavigationThrottle::ThrottleCheckResult result);

+ void OnStartChecksComplete(

+ NavigationThrottle::ThrottleCheckResult result,

+ const std::vector<std::pair<std:: string, std::string>>&

nasko 2015/11/06 23:51:51 Why not NavigationHandleImpl::ExtraHeadersList? Yo

clamy 2015/11/09 15:47:09 Done.

+ extra_headers_list);

+ void OnRedirectChecksComplete(

+ NavigationThrottle::ThrottleCheckResult result,

+ const std::vector<std::pair<std:: string, std::string>>&

nasko 2015/11/06 23:51:51 Same here.

clamy 2015/11/09 15:47:09 Done.

+ extra_headers_list);

FrameTreeNode* frame_tree_node_;