Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 1416943005: Revert of [es6] Better support for built-ins subclassing. (Closed)

Created:
5 years, 1 month ago by Benedikt Meurer
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [es6] Better support for built-ins subclassing. (patchset #8 id:200001 of https://codereview.chromium.org/1427483002/ ) Reason for revert: Breaks test on win32 nosnap.http://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20nosnap%20-%20shared/builds/9680 Original issue's description: > [es6] Better support for built-ins subclassing. > > Create proper initial map for original constructor (new.target) instead of doing prototype transition on the base constructor's initial map. This approach fixes in-object slack tracking for subclass instances. > This CL also fixes subclassing from String. > > BUG=v8:3101, v8:3330 > LOG=Y > > Committed: https://crrev.com/cd5f48302a502154a0106d12e3066bd563c6340c > Cr-Commit-Position: refs/heads/master@{#31680} TBR=verwaest@chromium.org,ulan@chromium.org,ishell@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3101, v8:3330 Committed: https://crrev.com/08ca3f240c6c279e956af8fd1b525abd4edf8ff7 Cr-Commit-Position: refs/heads/master@{#31684}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -792 lines) Patch
M src/arm/builtins-arm.cc View 4 chunks +13 lines, -33 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 5 chunks +6 lines, -24 lines 0 comments Download
M src/heap/heap.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/builtins-ia32.cc View 5 chunks +4 lines, -28 lines 0 comments Download
M src/mips/builtins-mips.cc View 5 chunks +4 lines, -21 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 5 chunks +4 lines, -21 lines 0 comments Download
M src/objects.h View 5 chunks +6 lines, -20 lines 0 comments Download
M src/objects.cc View 4 chunks +20 lines, -134 lines 0 comments Download
M src/objects-inl.h View 3 chunks +9 lines, -20 lines 0 comments Download
M src/objects-printer.cc View 5 chunks +18 lines, -30 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +36 lines, -21 lines 0 comments Download
M src/runtime/runtime-typedarray.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M src/x64/builtins-x64.cc View 5 chunks +5 lines, -28 lines 0 comments Download
D test/mjsunit/es6/classes-subclass-builtins.js View 1 chunk +0 lines, -405 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Benedikt Meurer
Created Revert of [es6] Better support for built-ins subclassing.
5 years, 1 month ago (2015-10-30 11:36:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1416943005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1416943005/1
5 years, 1 month ago (2015-10-30 11:36:14 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-30 11:36:28 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 11:36:41 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/08ca3f240c6c279e956af8fd1b525abd4edf8ff7
Cr-Commit-Position: refs/heads/master@{#31684}

Powered by Google App Engine
This is Rietveld 408576698