Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 1416943004: Use OTS_TAG in BlinkOTSContext::GetTableAction. (Closed)

Created:
5 years, 1 month ago by bungeman-chromium
Modified:
5 years, 1 month ago
CC:
chromium-reviews, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, Rik, blink-reviews-platform-graphics_chromium.org, dshwang, jbroman, Justin Novosad, danakj, krit, f(malita), blink-reviews, vmpstr+blinkwatch_chromium.org, Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use OTS_TAG in BlinkOTSContext::GetTableAction. BlinkOTSContext::GetTableAction currently uses a custom TABLE_TAG macro which is almost exactly the same as OTS_TAG, but OTS_TAG is the blessed way to create tags for use with OTS. Committed: https://crrev.com/e847d641a730772aad301292a8b346a147996f9e Cr-Commit-Position: refs/heads/master@{#357117}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -10 lines) Patch
M third_party/WebKit/Source/platform/fonts/opentype/OpenTypeSanitizer.cpp View 2 chunks +7 lines, -10 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1416943004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1416943004/1
5 years, 1 month ago (2015-10-29 21:15:39 UTC) #2
bungeman-chromium
Sorry for the noise, but it appears the plan now is to land this change ...
5 years, 1 month ago (2015-10-29 21:17:08 UTC) #4
behdad
lgtm
5 years, 1 month ago (2015-10-29 21:40:38 UTC) #5
eae
LGTM
5 years, 1 month ago (2015-10-29 22:07:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1416943004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1416943004/1
5 years, 1 month ago (2015-10-29 22:09:43 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/127830)
5 years, 1 month ago (2015-10-29 23:51:12 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1416943004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1416943004/1
5 years, 1 month ago (2015-10-30 14:59:11 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-30 16:14:21 UTC) #14
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 16:15:11 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e847d641a730772aad301292a8b346a147996f9e
Cr-Commit-Position: refs/heads/master@{#357117}

Powered by Google App Engine
This is Rietveld 408576698