Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 141693007: Delete some msvs_cygwin_shell:0 (Closed)

Created:
6 years, 11 months ago by scottmg
Modified:
6 years, 11 months ago
Reviewers:
Nico
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Delete some msvs_cygwin_shell:0 This is the default, so these are no-ops. TBR=thakis@chromium.org BUG=123026 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247039

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M build/grit_action.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M build/isolate.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M build/protoc.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M build/win/importlibs/create_import_lib.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_syzygy.gypi View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scottmg
6 years, 11 months ago (2014-01-24 22:25:36 UTC) #1
Nico
lgtm (I was somewhat worried that some gyp file somewhere set this to 1 and ...
6 years, 11 months ago (2014-01-24 22:27:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/141693007/1
6 years, 11 months ago (2014-01-24 22:32:03 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-25 00:45:50 UTC) #4
Message was sent while issue was closed.
Change committed as 247039

Powered by Google App Engine
This is Rietveld 408576698