Issue 141693002: Don't support mixed dashed/camel-cased CSS property names

Issue 141693002: Don't support mixed dashed/camel-cased CSS property names (Closed)

Created:
6 years, 11 months ago by Jens Widell

Modified:
6 years, 11 months ago

Reviewers:
jochen (gone - plz use gerrit), ojan

CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, haraken, Nate Chapin, Inactive

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Don't support mixed dashed/camel-cased CSS property names CSSStyleDeclaration's custom getter and setter support property names that are either dashed ("border-top-width") or camel-cased ("borderTopWidth") but shouldn't support names that are both (such as "border-topWidth".) BUG=334562 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165331

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+63 lines, -0 lines)			Patch
A	LayoutTests/fast/dom/CSSStyleDeclaration/css-style-declaration-named-getter.html	View	1 chunk	+32 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/dom/CSSStyleDeclaration/css-style-declaration-named-getter-expected.txt	View	1 chunk	+24 lines, -0 lines	0 comments	Download
M	Source/bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp	View	2 chunks	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Jens Widell

PTAL. Dropping support for outright weird names while we decide how to handle http://crbug.com/290055.

6 years, 11 months ago (2014-01-17 12:27:46 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jl@opera.com/141693002/1

6 years, 11 months ago (2014-01-17 18:22:35 UTC) #4

commit-bot: I haz the power

Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=14247

6 years, 11 months ago (2014-01-17 18:50:53 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jl@opera.com/141693002/1

6 years, 11 months ago (2014-01-17 18:53:10 UTC) #7

Message was sent while issue was closed.

Change committed as 165331

Expand Messages | Collapse Messages