Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1416893002: Add roundtrip tests to SpdyAltSvcWireFormat. (Closed)

Created:
5 years, 2 months ago by Bence
Modified:
5 years, 2 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add roundtrip tests to SpdyAltSvcWireFormat. SpdyAltSvcWireFormat performs two distinct roles: parsing and serializing. This CL adds roundtrip tests to make sure that these functionalities are compatible. This CL lands server change 105756554 by bnc. BUG=488484 Committed: https://crrev.com/b0d839cc937b4e16a8d3c820f28c52fee158fb22 Cr-Commit-Position: refs/heads/master@{#355114}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -4 lines) Patch
M net/spdy/spdy_alt_svc_wire_format_test.cc View 7 chunks +84 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Bence
Ryan: PTAL. Thank you.
5 years, 2 months ago (2015-10-20 17:41:03 UTC) #1
Bence
Ryan: PTAL. Thank you.
5 years, 2 months ago (2015-10-20 17:41:09 UTC) #3
Ryan Hamilton
lgtm
5 years, 2 months ago (2015-10-20 17:57:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1416893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1416893002/1
5 years, 2 months ago (2015-10-20 18:24:54 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-20 18:37:37 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-20 18:38:22 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b0d839cc937b4e16a8d3c820f28c52fee158fb22
Cr-Commit-Position: refs/heads/master@{#355114}

Powered by Google App Engine
This is Rietveld 408576698