Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(987)

Issue 1416883002: Mjsunit/debug-script test fails intermittendly with --vector-stores (Closed)

Created:
5 years, 2 months ago by mvstanton
Modified:
5 years, 2 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Mjsunit/debug-script test fails intermittendly with --vector-stores The problem is that the gc pattern is different, and the list of debug scripts may have more or less duplicates than before. The solution is to just turn off --stress-opt for the test. R=yangguo@chromium.org BUG=v8:4502 LOG=N Committed: https://crrev.com/aeffa39e1df8697107168b4c483b3c6bc73a5d97 Cr-Commit-Position: refs/heads/master@{#31415}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M test/mjsunit/debug-script.js View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mvstanton
Hi Yang, here is the change we discussed, thx!
5 years, 2 months ago (2015-10-20 13:56:10 UTC) #2
Yang
lgtm
5 years, 2 months ago (2015-10-20 13:57:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1416883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1416883002/1
5 years, 2 months ago (2015-10-20 14:05:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-20 14:57:16 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-20 14:57:31 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aeffa39e1df8697107168b4c483b3c6bc73a5d97
Cr-Commit-Position: refs/heads/master@{#31415}

Powered by Google App Engine
This is Rietveld 408576698