Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(909)

Issue 1416873008: [runtime] Handle Exceptions from Indexed- and NamedInterceptor (Closed)

Created:
5 years, 1 month ago by Camillo Bruni
Modified:
5 years, 1 month ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Handle Exceptions from Indexed- and NamedInterceptor LOG=N BUG=v8:4026 Committed: https://crrev.com/c05137e108b9b359385f9985a09f5a4bb2514637 Cr-Commit-Position: refs/heads/master@{#31580}

Patch Set 1 #

Total comments: 2

Patch Set 2 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -0 lines) Patch
M src/objects.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M test/cctest/test-api-interceptors.cc View 1 1 chunk +90 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1416873008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1416873008/1
5 years, 1 month ago (2015-10-26 15:57:30 UTC) #3
Camillo Bruni
PTAL
5 years, 1 month ago (2015-10-26 16:07:06 UTC) #5
Jakob Kummerow
LGTM if you fix the two major bugs that I found :-P https://codereview.chromium.org/1416873008/diff/1/test/cctest/test-api-interceptors.cc File test/cctest/test-api-interceptors.cc ...
5 years, 1 month ago (2015-10-26 16:12:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1416873008/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1416873008/20001
5 years, 1 month ago (2015-10-26 16:15:49 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-10-26 17:24:21 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-10-26 17:25:12 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c05137e108b9b359385f9985a09f5a4bb2514637
Cr-Commit-Position: refs/heads/master@{#31580}

Powered by Google App Engine
This is Rietveld 408576698