Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 1416873007: [turbofan] Enable general purpose inlining. (Closed)

Created:
5 years, 1 month ago by Michael Starzinger
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Enable general purpose inlining. R=bmeurer@chromium.org,hablich@chromium.org BUG=v8:4493 LOG=n Committed: https://crrev.com/161a0462fb0e79f155f3ea085ba774dad99539cb Cr-Commit-Position: refs/heads/master@{#31634}

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/flag-definitions.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (2 generated)
Michael Starzinger
5 years, 1 month ago (2015-10-26 14:12:09 UTC) #1
Benedikt Meurer
LGTM!
5 years, 1 month ago (2015-10-26 14:21:57 UTC) #2
Michael Hablich
On 2015/10/26 14:21:57, Benedikt Meurer wrote: > LGTM! A new Dev will be released tomorrow ...
5 years, 1 month ago (2015-10-26 14:33:12 UTC) #3
Michael Starzinger
On 2015/10/26 14:33:12, Hablich wrote: > On 2015/10/26 14:21:57, Benedikt Meurer wrote: > > LGTM! ...
5 years, 1 month ago (2015-10-26 14:42:40 UTC) #4
Michael Starzinger
On 2015/10/26 14:42:40, Michael Starzinger wrote: > On 2015/10/26 14:33:12, Hablich wrote: > > On ...
5 years, 1 month ago (2015-10-28 14:38:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1416873007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1416873007/20001
5 years, 1 month ago (2015-10-28 15:42:04 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-10-28 15:43:15 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/161a0462fb0e79f155f3ea085ba774dad99539cb Cr-Commit-Position: refs/heads/master@{#31634}
5 years, 1 month ago (2015-10-28 15:43:40 UTC) #10
Michael Hablich
5 years, 1 month ago (2015-11-06 13:07:41 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1409153008/ by hablich@chromium.org.

The reason for reverting is: As discussed with Benedikt: Disable
--turbo-inlining again because it tanks Jetstream..

Powered by Google App Engine
This is Rietveld 408576698