Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Issue 1416863003: Fix PackageUriResolver.restoreAbsolute on Windows (Closed)

Created:
5 years, 2 months ago by Paul Berry
Modified:
5 years, 2 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix PackageUriResolver.restoreAbsolute on Windows Previously, this method attempted to create a package URI by appending part of a filesystem path to "package:"; on Windows this resulted in nonsense URIs like "package:foo\bar.dart". Now we transform the filesystem paths to "file:" URIs before doing other computations; this normalizes the path separator to "/", so we can safely use part of the resulting URIs to construct a "package:" URI. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/4e41dc0d66d240e20a5e470b66d9071ffad96094

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M pkg/analyzer/lib/src/generated/source_io.dart View 2 chunks +11 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
5 years, 2 months ago (2015-10-20 16:46:06 UTC) #2
Brian Wilkerson
LGTM
5 years, 2 months ago (2015-10-20 16:48:05 UTC) #3
Paul Berry
5 years, 2 months ago (2015-10-20 16:56:28 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4e41dc0d66d240e20a5e470b66d9071ffad96094 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698