Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1416843003: Add support for client certificates to Secure[Server]Socket (Closed)

Created:
5 years, 2 months ago by Bill Hesse
Modified:
5 years, 2 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add support for client certificates to Secure[Server]Socket BUG=https://github.com/dart-lang/sdk/issues/24069 BUG=https://github.com/dart-lang/sdk/issues/24070 R=sgjesse@google.com Committed: https://github.com/dart-lang/sdk/commit/b519e4c0001a0e84a7b45634057d0b4b51f0dd57

Patch Set 1 #

Patch Set 2 : Fix formatting #

Total comments: 2

Patch Set 3 : Address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+310 lines, -354 lines) Patch
M runtime/bin/secure_socket.cc View 3 chunks +7 lines, -17 lines 0 comments Download
M tests/standalone/io/certificates/server_chain.pem View 1 chunk +48 lines, -46 lines 0 comments Download
M tests/standalone/io/certificates/server_key.pem View 1 chunk +27 lines, -27 lines 0 comments Download
M tests/standalone/io/certificates/trusted_certs.pem View 1 chunk +14 lines, -14 lines 0 comments Download
M tests/standalone/io/certificates/untrusted_server_chain.pem View 1 chunk +48 lines, -46 lines 0 comments Download
M tests/standalone/io/certificates/untrusted_server_key.pem View 1 chunk +27 lines, -27 lines 0 comments Download
M tests/standalone/io/create_sample_certificates.sh View 1 2 1 chunk +42 lines, -7 lines 0 comments Download
D tests/standalone/io/intermediate_authority_v3_extensions View 1 chunk +0 lines, -11 lines 0 comments Download
D tests/standalone/io/localhost_v3_extensions View 1 chunk +0 lines, -18 lines 0 comments Download
A tests/standalone/io/sample_certificate_v3_extensions View 1 chunk +46 lines, -0 lines 0 comments Download
M tests/standalone/io/secure_server_client_certificate_test.dart View 1 1 chunk +51 lines, -64 lines 0 comments Download
D tests/standalone/io/secure_server_client_no_certificate_test.dart View 1 chunk +0 lines, -75 lines 0 comments Download
M tests/standalone/standalone.status View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Bill Hesse
5 years, 2 months ago (2015-10-20 14:43:31 UTC) #2
Søren Gjesse
LGTM! https://codereview.chromium.org/1416843003/diff/20001/tests/standalone/io/create_sample_certificates.sh File tests/standalone/io/create_sample_certificates.sh (right): https://codereview.chromium.org/1416843003/diff/20001/tests/standalone/io/create_sample_certificates.sh#newcode83 tests/standalone/io/create_sample_certificates.sh:83: # BoringSSL only accepts private keys signed with ...
5 years, 2 months ago (2015-10-20 15:12:48 UTC) #3
Bill Hesse
https://codereview.chromium.org/1416843003/diff/20001/tests/standalone/io/create_sample_certificates.sh File tests/standalone/io/create_sample_certificates.sh (right): https://codereview.chromium.org/1416843003/diff/20001/tests/standalone/io/create_sample_certificates.sh#newcode83 tests/standalone/io/create_sample_certificates.sh:83: # BoringSSL only accepts private keys signed with the ...
5 years, 2 months ago (2015-10-20 15:18:46 UTC) #4
Bill Hesse
5 years, 2 months ago (2015-10-20 15:19:02 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
b519e4c0001a0e84a7b45634057d0b4b51f0dd57 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698