Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(868)

Unified Diff: pkg/mdns/lib/src/native_extension_client.dart

Issue 1416833009: Add multiple results and timeout handling to the Mac OS mDNS native extension (Closed) Base URL: git@github.com:dart-lang/fletch.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/pkg/mdns/mdns_extension.h » ('j') | src/pkg/mdns/mdns_extension_macos.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/mdns/lib/src/native_extension_client.dart
diff --git a/pkg/mdns/lib/src/native_extension_client.dart b/pkg/mdns/lib/src/native_extension_client.dart
index 9b37f15c8b9459604af5f5f6b599c0f82aa537c8..9e6d836ccc4bc7b81cc8ae47d1ccdfca31f9a4f4 100644
--- a/pkg/mdns/lib/src/native_extension_client.dart
+++ b/pkg/mdns/lib/src/native_extension_client.dart
@@ -70,10 +70,17 @@ class NativeExtensionMDnsClient implements MDnsClient {
var result = _resolver.addPendingRequest(type, name, timeout);
// Send the request.
+ //
+ // response[0]: reply port (SendPort)
+ // response[1]: request type (int)
+ // response[2]: record type (int)
+ // response[3]: data (Uint8List)
+ // response[4]: timeout in milliseconds (int)
_service.send([_incoming.sendPort,
RequestType.lookupRequest.index,
type,
- name]);
+ name,
+ timeout.inMilliseconds]);
return result;
}
« no previous file with comments | « no previous file | src/pkg/mdns/mdns_extension.h » ('j') | src/pkg/mdns/mdns_extension_macos.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698