Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 1416833009: Add multiple results and timeout handling to the Mac OS mDNS native extension (Closed)

Created:
5 years, 1 month ago by Søren Gjesse
Modified:
5 years, 1 month ago
Reviewers:
wibling, karlklose
CC:
fletch+reviews_googlegroups.com
Base URL:
git@github.com:dart-lang/fletch.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add multiple results and timeout handling to the Mac OS mDNS native extension The mDNS native extension on Mac OS now keeps sending results until the given timeout period has expired. To make that happen changed the thread pumping the results to use select on the privided file descriptor for the given timeout period. R=wibling@google.com, karlklose@google.com BUG= Committed: https://github.com/dart-lang/fletch/commit/5c4d55e13f559d010b9294b14fc2eb6e6fbb9660

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed review comments and added new SHA1 for native extension #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+297 lines, -134 lines) Patch
M pkg/mdns/lib/native/libmdns_extension_lib.dylib.sha1 View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/mdns/lib/src/constants.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/mdns/lib/src/native_extension_client.dart View 1 2 chunks +49 lines, -18 lines 0 comments Download
M pkg/mdns/lib/src/packet.dart View 1 3 chunks +61 lines, -44 lines 0 comments Download
M pkg/mdns/test/decode_test.dart View 1 3 chunks +41 lines, -0 lines 1 comment Download
M src/pkg/mdns/mdns_extension.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/mdns/mdns_extension.cc View 1 1 chunk +29 lines, -17 lines 0 comments Download
M src/pkg/mdns/mdns_extension_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/mdns/mdns_extension_macos.cc View 1 5 chunks +112 lines, -52 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Søren Gjesse
This is based on top of https://codereview.chromium.org/1411063006/. There is no new sha1 file for the ...
5 years, 1 month ago (2015-11-10 10:15:30 UTC) #1
wibling
lgtm https://codereview.chromium.org/1416833009/diff/1/src/pkg/mdns/mdns_extension_macos.cc File src/pkg/mdns/mdns_extension_macos.cc (right): https://codereview.chromium.org/1416833009/diff/1/src/pkg/mdns/mdns_extension_macos.cc#newcode88 src/pkg/mdns/mdns_extension_macos.cc:88: result = DNSServiceProcessResult(ctx->ref); NIT: Merge the two above ...
5 years, 1 month ago (2015-11-10 14:44:56 UTC) #3
Søren Gjesse
Committed patchset #2 (id:20001) manually as 5c4d55e13f559d010b9294b14fc2eb6e6fbb9660.
5 years, 1 month ago (2015-11-10 15:22:40 UTC) #4
Søren Gjesse
https://codereview.chromium.org/1416833009/diff/1/src/pkg/mdns/mdns_extension_macos.cc File src/pkg/mdns/mdns_extension_macos.cc (right): https://codereview.chromium.org/1416833009/diff/1/src/pkg/mdns/mdns_extension_macos.cc#newcode88 src/pkg/mdns/mdns_extension_macos.cc:88: result = DNSServiceProcessResult(ctx->ref); On 2015/11/10 14:44:56, wibling wrote: > ...
5 years, 1 month ago (2015-11-10 15:30:05 UTC) #5
karlklose
5 years, 1 month ago (2015-11-12 10:37:07 UTC) #6
Message was sent while issue was closed.
LGTM.

https://codereview.chromium.org/1416833009/diff/20001/pkg/mdns/test/decode_te...
File pkg/mdns/test/decode_test.dart (right):

https://codereview.chromium.org/1416833009/diff/20001/pkg/mdns/test/decode_te...
pkg/mdns/test/decode_test.dart:34: RR 16 [0]
These tests already test PTR, SRV, and TXT decoding, but they use
ResourceRecord.toString() instead. I think we should unify the way we test this.

Powered by Google App Engine
This is Rietveld 408576698