Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Issue 141683005: Removes MessageLoop::Type checks in favor of IsCurrent on MessageLoops. (Closed)

Created:
6 years, 11 months ago by sky
Modified:
6 years, 11 months ago
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, amit, dcheng, frankf, yukishiino+watch_chromium.org, stevenjb+watch_chromium.org, yusukes+watch_chromium.org, dcaiafa+watch_chromium.org, cbentzel+watch_chromium.org, jam, joi+watch-content_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, michaeln, kalyank, erikwright+watch_chromium.org, rjkroege, ozone-reviews_chromium.org, wez+watch_chromium.org, sanjeevr, penghuang+watch_chromium.org, feature-media-reviews_chromium.org, rmsousa+watch_chromium.org, oshima+watch_chromium.org, sergeyu+watch_chromium.org, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, tfarina, chrisgao (Use stgao instead), garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, weitaosu+watch_chromium.org, alexeypa+watch_chromium.org, James Su, davemoore+watch_chromium.org
Visibility:
Public.

Description

Removes MessageLoop::Type checks in favor of IsCurrent on MessageLoops. This is part of removing the MessageLoop::Type enum. BUG=none TEST=none R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245882

Patch Set 1 #

Patch Set 2 : ugh #

Patch Set 3 : DCHECK_EQ->DCHECK #

Patch Set 4 : DCHECK_EQ->DCHECK #

Patch Set 5 : missing paren #

Patch Set 6 : ASSERT_TRUE #

Patch Set 7 : base:: #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -113 lines) Patch
M base/message_loop/message_loop.h View 2 chunks +10 lines, -0 lines 0 comments Download
M base/power_monitor/power_monitor_device_source_win.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_browser_main.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/screen_locker.cc View 1 2 3 4 5 6 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/external_protocol/external_protocol_handler.cc View 1 2 3 4 5 6 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/jankometer.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/printing/print_job.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/printer_query.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/external_protocol_dialog.mm View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/protocol_dialog_gtk.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/uninstall_view.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/user_data_dir_dialog_view.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/chrome/adb_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/service/win/cloud_print_service_config.cc View 8 chunks +10 lines, -10 lines 0 comments Download
M content/browser/browser_main_loop.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/audio_manager_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/dns_reloader.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M net/cert/cert_database_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket_stream/socket_stream.cc View 1 2 6 chunks +6 lines, -6 lines 0 comments Download
M remoting/host/desktop_process.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/win/rdp_client.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/base/clipboard/clipboard_win.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/base/ime/win/tsf_bridge.cc View 1 2 3 4 12 chunks +12 lines, -12 lines 0 comments Download
M ui/base/ime/win/tsf_input_scope.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/base/test/ui_controls_mac.mm View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/ozone/dri/dri_surface_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/win/singleton_hwnd.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M webkit/browser/appcache/appcache_update_job_unittest.cc View 1 2 3 4 5 53 chunks +53 lines, -53 lines 0 comments Download
M win8/metro_driver/ime/ime_popup_monitor.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
sky
6 years, 11 months ago (2014-01-17 21:40:12 UTC) #1
darin (slow to review)
LGTM
6 years, 11 months ago (2014-01-20 05:21:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/141683005/170006
6 years, 11 months ago (2014-01-20 06:37:41 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-20 08:59:57 UTC) #4
Message was sent while issue was closed.
Change committed as 245882

Powered by Google App Engine
This is Rietveld 408576698