Source/core/html/LabelsNodeList.cpp - Issue 141683004: Use more const references in HTMLCollection / LiveNodeList

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/LabelsNodeList.cpp

Issue 141683004: Use more const references in HTMLCollection / LiveNodeList (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Get rid of const_cast Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/LabelsNodeList.cpp

diff --git a/Source/core/html/LabelsNodeList.cpp b/Source/core/html/LabelsNodeList.cpp

index adf5141d7eb5f927255ed2b067548dc1e6aa9ca4..759205071a8d08ca0e1020dc0d2be26b2eca0403 100644

--- a/Source/core/html/LabelsNodeList.cpp

+++ b/Source/core/html/LabelsNodeList.cpp

@@ -43,9 +43,9 @@ LabelsNodeList::~LabelsNodeList()

ownerNode()->nodeLists()->removeCacheWithAtomicName(this, LabelsNodeListType, starAtom);

}

-bool LabelsNodeList::nodeMatches(Element* testNode) const

+bool LabelsNodeList::nodeMatches(const Element& testNode) const

{

- return testNode->hasTagName(labelTag) && toHTMLLabelElement(testNode)->control() == ownerNode();

+ return testNode.hasTagName(labelTag) && toHTMLLabelElement(testNode).control() == ownerNode();

}

} // namespace WebCore

« no previous file with comments | « Source/core/html/LabelsNodeList.h ('k') | Source/core/html/RadioNodeList.h » ('j') | no next file with comments »