Source/core/html/HTMLOptionElement.cpp - Issue 141683004: Use more const references in HTMLCollection / LiveNodeList

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLOptionElement.cpp

Issue 141683004: Use more const references in HTMLCollection / LiveNodeList (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Get rid of const_cast Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLOptionElement.cpp

diff --git a/Source/core/html/HTMLOptionElement.cpp b/Source/core/html/HTMLOptionElement.cpp

index 13f6e2b7b943f85a0f5ad866c7901ba44a758d1c..b52c4c999d637cc87957b7dce210c7b7ae78b2bb 100644

--- a/Source/core/html/HTMLOptionElement.cpp

+++ b/Source/core/html/HTMLOptionElement.cpp

@@ -201,7 +201,7 @@ void HTMLOptionElement::setValue(const AtomicString& value)

setAttribute(valueAttr, value);

}

-bool HTMLOptionElement::selected()

+bool HTMLOptionElement::selected() const

{

if (HTMLSelectElement* select = ownerSelectElement()) {

// If a stylesheet contains option:checked selectors, this function is

« no previous file with comments | « Source/core/html/HTMLOptionElement.h ('k') | Source/core/html/LabelsNodeList.h » ('j') | no next file with comments »