Source/core/dom/NameNodeList.cpp - Issue 141683004: Use more const references in HTMLCollection / LiveNodeList

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/NameNodeList.cpp

Issue 141683004: Use more const references in HTMLCollection / LiveNodeList (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Get rid of const_cast Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/NameNodeList.cpp

diff --git a/Source/core/dom/NameNodeList.cpp b/Source/core/dom/NameNodeList.cpp

index 69634c9f48a474418533f4b0399405c4fb8e5f42..490733f84077e07961f1b8e48843235f08a31e72 100644

--- a/Source/core/dom/NameNodeList.cpp

+++ b/Source/core/dom/NameNodeList.cpp

@@ -42,9 +42,9 @@ NameNodeList::~NameNodeList()

ownerNode()->nodeLists()->removeCacheWithAtomicName(this, NameNodeListType, m_name);

}

-bool NameNodeList::nodeMatches(Element* testNode) const

+bool NameNodeList::nodeMatches(const Element& testNode) const

{

- return testNode->getNameAttribute() == m_name;

+ return testNode.getNameAttribute() == m_name;

}

} // namespace WebCore

« no previous file with comments | « Source/core/dom/NameNodeList.h ('k') | Source/core/dom/TagNodeList.h » ('j') | no next file with comments »