Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Side by Side Diff: Source/core/html/HTMLCollection.h

Issue 141683004: Use more const references in HTMLCollection / LiveNodeList (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Get rid of const_cast Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/dom/TagNodeList.cpp ('k') | Source/core/html/HTMLCollection.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2011, 2012 Apple Inc. All r ights reserved. 4 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2011, 2012 Apple Inc. All r ights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 { 54 {
55 if (isLengthCacheValid()) 55 if (isLengthCacheValid())
56 return cachedLength() == 1; 56 return cachedLength() == 1;
57 if (cachedItem()) 57 if (cachedItem())
58 return !cachedItemOffset() && !item(1); 58 return !cachedItemOffset() && !item(1);
59 return item(0) && !item(1); 59 return item(0) && !item(1);
60 } 60 }
61 61
62 virtual Element* virtualItemAfter(Element*) const; 62 virtual Element* virtualItemAfter(Element*) const;
63 63
64 Element* traverseToFirstElement(ContainerNode& root) const; 64 Element* traverseToFirstElement(const ContainerNode& root) const;
65 Element* traverseForwardToOffset(unsigned offset, Element& currentElement, u nsigned& currentOffset, ContainerNode* root) const; 65 Element* traverseForwardToOffset(unsigned offset, Element& currentElement, u nsigned& currentOffset, const ContainerNode& root) const;
66 66
67 protected: 67 protected:
68 HTMLCollection(Node* base, CollectionType, ItemAfterOverrideType); 68 HTMLCollection(Node* base, CollectionType, ItemAfterOverrideType);
69 69
70 virtual void updateNameCache() const; 70 virtual void updateNameCache() const;
71 bool hasNameCache() const { return m_isNameCacheValid; } 71 bool hasNameCache() const { return m_isNameCacheValid; }
72 void setHasNameCache() const { m_isNameCacheValid = true; } 72 void setHasNameCache() const { m_isNameCacheValid = true; }
73 73
74 typedef HashMap<StringImpl*, OwnPtr<Vector<Element*> > > NodeCacheMap; 74 typedef HashMap<StringImpl*, OwnPtr<Vector<Element*> > > NodeCacheMap;
75 Vector<Element*>* idCache(const AtomicString& name) const { return m_idCache .get(name.impl()); } 75 Vector<Element*>* idCache(const AtomicString& name) const { return m_idCache .get(name.impl()); }
76 Vector<Element*>* nameCache(const AtomicString& name) const { return m_nameC ache.get(name.impl()); } 76 Vector<Element*>* nameCache(const AtomicString& name) const { return m_nameC ache.get(name.impl()); }
77 void appendIdCache(const AtomicString& name, Element* element) const { appen d(m_idCache, name, element); } 77 void appendIdCache(const AtomicString& name, Element* element) const { appen d(m_idCache, name, element); }
78 void appendNameCache(const AtomicString& name, Element* element) const { app end(m_nameCache, name, element); } 78 void appendNameCache(const AtomicString& name, Element* element) const { app end(m_nameCache, name, element); }
79 79
80 private: 80 private:
81 bool checkForNameMatch(Element*, bool checkName, const AtomicString& name) c onst; 81 bool checkForNameMatch(const Element&, bool checkName, const AtomicString& n ame) const;
82 Element* traverseNextElement(Element& previous, ContainerNode* root) const; 82 Element* traverseNextElement(Element& previous, const ContainerNode& root) c onst;
83 83
84 static void append(NodeCacheMap&, const AtomicString&, Element*); 84 static void append(NodeCacheMap&, const AtomicString&, Element*);
85 void invalidateIdNameCacheMaps() const 85 void invalidateIdNameCacheMaps() const
86 { 86 {
87 m_idCache.clear(); 87 m_idCache.clear();
88 m_nameCache.clear(); 88 m_nameCache.clear();
89 m_isNameCacheValid = false; 89 m_isNameCacheValid = false;
90 } 90 }
91 91
92 mutable unsigned m_isNameCacheValid : 1; 92 mutable unsigned m_isNameCacheValid : 1;
93 mutable NodeCacheMap m_idCache; 93 mutable NodeCacheMap m_idCache;
94 mutable NodeCacheMap m_nameCache; 94 mutable NodeCacheMap m_nameCache;
95 95
96 friend class LiveNodeListBase; 96 friend class LiveNodeListBase;
97 }; 97 };
98 98
99 } // namespace 99 } // namespace
100 100
101 #endif 101 #endif
OLDNEW
« no previous file with comments | « Source/core/dom/TagNodeList.cpp ('k') | Source/core/html/HTMLCollection.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698