Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Side by Side Diff: Source/core/dom/TagNodeList.h

Issue 141683004: Use more const references in HTMLCollection / LiveNodeList (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Get rid of const_cast Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/dom/NameNodeList.cpp ('k') | Source/core/dom/TagNodeList.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
6 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) 6 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 { 43 {
44 ASSERT_UNUSED(type, type == TagNodeListType); 44 ASSERT_UNUSED(type, type == TagNodeListType);
45 return adoptRef(new TagNodeList(rootNode, TagNodeListType, starAtom, loc alName)); 45 return adoptRef(new TagNodeList(rootNode, TagNodeListType, starAtom, loc alName));
46 } 46 }
47 47
48 virtual ~TagNodeList(); 48 virtual ~TagNodeList();
49 49
50 protected: 50 protected:
51 TagNodeList(PassRefPtr<Node> rootNode, CollectionType, const AtomicString& n amespaceURI, const AtomicString& localName); 51 TagNodeList(PassRefPtr<Node> rootNode, CollectionType, const AtomicString& n amespaceURI, const AtomicString& localName);
52 52
53 virtual bool nodeMatches(Element*) const OVERRIDE; 53 virtual bool nodeMatches(const Element&) const OVERRIDE;
54 54
55 AtomicString m_namespaceURI; 55 AtomicString m_namespaceURI;
56 AtomicString m_localName; 56 AtomicString m_localName;
57 }; 57 };
58 58
59 class HTMLTagNodeList FINAL : public TagNodeList { 59 class HTMLTagNodeList FINAL : public TagNodeList {
60 public: 60 public:
61 static PassRefPtr<HTMLTagNodeList> create(PassRefPtr<Node> rootNode, Collect ionType type, const AtomicString& localName) 61 static PassRefPtr<HTMLTagNodeList> create(PassRefPtr<Node> rootNode, Collect ionType type, const AtomicString& localName)
62 { 62 {
63 ASSERT_UNUSED(type, type == HTMLTagNodeListType); 63 ASSERT_UNUSED(type, type == HTMLTagNodeListType);
64 return adoptRef(new HTMLTagNodeList(rootNode, localName)); 64 return adoptRef(new HTMLTagNodeList(rootNode, localName));
65 } 65 }
66 66
67 bool nodeMatchesInlined(Element*) const; 67 bool nodeMatchesInlined(const Element&) const;
68 68
69 private: 69 private:
70 HTMLTagNodeList(PassRefPtr<Node> rootNode, const AtomicString& localName); 70 HTMLTagNodeList(PassRefPtr<Node> rootNode, const AtomicString& localName);
71 71
72 virtual bool nodeMatches(Element*) const OVERRIDE; 72 virtual bool nodeMatches(const Element&) const OVERRIDE;
73 73
74 AtomicString m_loweredLocalName; 74 AtomicString m_loweredLocalName;
75 }; 75 };
76 76
77 inline bool HTMLTagNodeList::nodeMatchesInlined(Element* testNode) const 77 inline bool HTMLTagNodeList::nodeMatchesInlined(const Element& testNode) const
78 { 78 {
79 // Implements http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#conce pt-getelementsbytagname 79 // Implements http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#conce pt-getelementsbytagname
80 if (m_localName != starAtom) { 80 if (m_localName != starAtom) {
81 const AtomicString& localName = testNode->isHTMLElement() ? m_loweredLoc alName : m_localName; 81 const AtomicString& localName = testNode.isHTMLElement() ? m_loweredLoca lName : m_localName;
82 if (localName != testNode->localName()) 82 if (localName != testNode.localName())
83 return false; 83 return false;
84 } 84 }
85 ASSERT(m_namespaceURI == starAtom); 85 ASSERT(m_namespaceURI == starAtom);
86 return true; 86 return true;
87 } 87 }
88 88
89 } // namespace WebCore 89 } // namespace WebCore
90 90
91 #endif // TagNodeList_h 91 #endif // TagNodeList_h
OLDNEW
« no previous file with comments | « Source/core/dom/NameNodeList.cpp ('k') | Source/core/dom/TagNodeList.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698