Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Side by Side Diff: Source/core/dom/LiveNodeList.cpp

Issue 141683004: Use more const references in HTMLCollection / LiveNodeList (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Get rid of const_cast Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/dom/LiveNodeList.h ('k') | Source/core/dom/NameNodeList.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2006, 2007, 2008, 2010 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2006, 2007, 2008, 2010 Apple Inc. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 ASSERT(hasIdNameCache()); 54 ASSERT(hasIdNameCache());
55 static_cast<const HTMLCollection*>(this)->invalidateIdNameCacheMaps(); 55 static_cast<const HTMLCollection*>(this)->invalidateIdNameCacheMaps();
56 } 56 }
57 57
58 Node* LiveNodeList::namedItem(const AtomicString& elementId) const 58 Node* LiveNodeList::namedItem(const AtomicString& elementId) const
59 { 59 {
60 Node& rootNode = this->rootNode(); 60 Node& rootNode = this->rootNode();
61 61
62 if (rootNode.inDocument()) { 62 if (rootNode.inDocument()) {
63 Element* element = rootNode.treeScope().getElementById(elementId); 63 Element* element = rootNode.treeScope().getElementById(elementId);
64 if (element && nodeMatches(element) && element->isDescendantOf(&rootNode )) 64 if (element && nodeMatches(*element) && element->isDescendantOf(&rootNod e))
65 return element; 65 return element;
66 if (!element) 66 if (!element)
67 return 0; 67 return 0;
68 // In the case of multiple nodes with the same name, just fall through. 68 // In the case of multiple nodes with the same name, just fall through.
69 } 69 }
70 70
71 unsigned length = this->length(); 71 unsigned length = this->length();
72 for (unsigned i = 0; i < length; i++) { 72 for (unsigned i = 0; i < length; i++) {
73 Node* node = item(i); 73 Node* node = item(i);
74 // FIXME: This should probably be using getIdAttribute instead of idForS tyleResolution. 74 // FIXME: This should probably be using getIdAttribute instead of idForS tyleResolution.
75 if (node->hasID() && toElement(node)->idForStyleResolution() == elementI d) 75 if (node->hasID() && toElement(node)->idForStyleResolution() == elementI d)
76 return node; 76 return node;
77 } 77 }
78 78
79 return 0; 79 return 0;
80 } 80 }
81 81
82 } // namespace WebCore 82 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/dom/LiveNodeList.h ('k') | Source/core/dom/NameNodeList.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698