Source/core/dom/ChildNodeList.cpp - Issue 141683004: Use more const references in HTMLCollection / LiveNodeList

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/dom/ChildNodeList.cpp

Issue 141683004: Use more const references in HTMLCollection / LiveNodeList (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Get rid of const_cast Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « Source/core/dom/ChildNodeList.h ('k') | Source/core/dom/ClassNodeList.h » ('j') | no next file with comments »

OLD	NEW
1 /**	1 /**

2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)	2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)

3 * (C) 1999 Antti Koivisto (koivisto@kde.org)	3 * (C) 1999 Antti Koivisto (koivisto@kde.org)

4 * (C) 2001 Dirk Mueller (mueller@kde.org)	4 * (C) 2001 Dirk Mueller (mueller@kde.org)

5 * Copyright (C) 2004, 2007, 2008 Apple Inc. All rights reserved.	5 * Copyright (C) 2004, 2007, 2008 Apple Inc. All rights reserved.

6 *	6 *

7 * This library is free software; you can redistribute it and/or	7 * This library is free software; you can redistribute it and/or

8 * modify it under the terms of the GNU Library General Public	8 * modify it under the terms of the GNU Library General Public

9 * License as published by the Free Software Foundation; either	9 * License as published by the Free Software Foundation; either

10 * version 2 of the License, or (at your option) any later version.	10 * version 2 of the License, or (at your option) any later version.

(...skipping 20 matching lines...) Expand all Loading...
31 ChildNodeList::ChildNodeList(PassRefPtr<Node> node)	31 ChildNodeList::ChildNodeList(PassRefPtr<Node> node)

32 : LiveNodeList(node, ChildNodeListType, DoNotInvalidateOnAttributeChanges)	32 : LiveNodeList(node, ChildNodeListType, DoNotInvalidateOnAttributeChanges)

33 {	33 {

34 }	34 }

35	35

36 ChildNodeList::~ChildNodeList()	36 ChildNodeList::~ChildNodeList()

37 {	37 {

38 ownerNode()->nodeLists()->removeChildNodeList(this);	38 ownerNode()->nodeLists()->removeChildNodeList(this);

39 }	39 }

40	40

41 bool ChildNodeList::nodeMatches(Element* testNode) const	41 bool ChildNodeList::nodeMatches(const Element& testNode) const

42 {	42 {

43 // This function will be called only by LiveNodeList::namedItem,	43 // This function will be called only by LiveNodeList::namedItem,

44 // for an element that was located with getElementById.	44 // for an element that was located with getElementById.

45 return testNode->parentNode() == rootNode();	45 return testNode.parentNode() == rootNode();

46 }	46 }

47	47

48 } // namespace WebCore	48 } // namespace WebCore

OLD	NEW