Source/core/html/LabelsNodeList.cpp - Issue 141683004: Use more const references in HTMLCollection / LiveNodeList

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/html/LabelsNodeList.cpp

Issue 141683004: Use more const references in HTMLCollection / LiveNodeList (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« Source/core/html/HTMLLabelElement.cpp ('K') | « Source/core/html/LabelsNodeList.h ('k') | Source/core/html/RadioNodeList.h » ('j') | no next file with comments »

OLD	NEW
1 /**	1 /**

2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)	2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)

3 * (C) 1999 Antti Koivisto (koivisto@kde.org)	3 * (C) 1999 Antti Koivisto (koivisto@kde.org)

4 * (C) 2001 Dirk Mueller (mueller@kde.org)	4 * (C) 2001 Dirk Mueller (mueller@kde.org)

5 * Copyright (C) 2004, 2007, 2008 Apple Inc. All rights reserved.	5 * Copyright (C) 2004, 2007, 2008 Apple Inc. All rights reserved.

6 * Copyright (C) 2010 Nokia Inc. All rights reserved.	6 * Copyright (C) 2010 Nokia Inc. All rights reserved.

7 *	7 *

8 * This library is free software; you can redistribute it and/or	8 * This library is free software; you can redistribute it and/or

9 * modify it under the terms of the GNU Library General Public	9 * modify it under the terms of the GNU Library General Public

10 * License as published by the Free Software Foundation; either	10 * License as published by the Free Software Foundation; either

(...skipping 25 matching lines...) Expand all Loading...
36 LabelsNodeList::LabelsNodeList(Node* ownerNode)	36 LabelsNodeList::LabelsNodeList(Node* ownerNode)

37 : LiveNodeList(ownerNode, LabelsNodeListType, InvalidateOnForAttrChange, Nod eListIsRootedAtDocument)	37 : LiveNodeList(ownerNode, LabelsNodeListType, InvalidateOnForAttrChange, Nod eListIsRootedAtDocument)

38 {	38 {

39 }	39 }

40	40

41 LabelsNodeList::~LabelsNodeList()	41 LabelsNodeList::~LabelsNodeList()

42 {	42 {

43 ownerNode()->nodeLists()->removeCacheWithAtomicName(this, LabelsNodeListType , starAtom);	43 ownerNode()->nodeLists()->removeCacheWithAtomicName(this, LabelsNodeListType , starAtom);

44 }	44 }

45	45

46 bool LabelsNodeList::nodeMatches(Element* testNode) const	46 bool LabelsNodeList::nodeMatches(const Element& testNode) const

47 {	47 {

48 return testNode->hasTagName(labelTag) && toHTMLLabelElement(testNode)->contr ol() == ownerNode();	48 return testNode.hasTagName(labelTag) && toHTMLLabelElement(testNode).control () == ownerNode();

49 }	49 }

50	50

51 } // namespace WebCore	51 } // namespace WebCore

OLD	NEW