Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Side by Side Diff: Source/core/dom/ClassNodeList.h

Issue 141683004: Use more const references in HTMLCollection / LiveNodeList (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007 Apple Inc. All rights reserved. 2 * Copyright (C) 2007 Apple Inc. All rights reserved.
3 * Copyright (C) 2007 David Smith (catfish.man@gmail.com) 3 * Copyright (C) 2007 David Smith (catfish.man@gmail.com)
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 8 *
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 // classNames argument is an AtomicString because it is common for Elements to share the same class names. 42 // classNames argument is an AtomicString because it is common for Elements to share the same class names.
43 // It is also used to construct a SpaceSplitString (m_classNames) and its co nstructor requires an AtomicString. 43 // It is also used to construct a SpaceSplitString (m_classNames) and its co nstructor requires an AtomicString.
44 static PassRefPtr<ClassNodeList> create(PassRefPtr<Node> rootNode, Collectio nType type, const AtomicString& classNames) 44 static PassRefPtr<ClassNodeList> create(PassRefPtr<Node> rootNode, Collectio nType type, const AtomicString& classNames)
45 { 45 {
46 ASSERT_UNUSED(type, type == ClassNodeListType); 46 ASSERT_UNUSED(type, type == ClassNodeListType);
47 return adoptRef(new ClassNodeList(rootNode, classNames)); 47 return adoptRef(new ClassNodeList(rootNode, classNames));
48 } 48 }
49 49
50 virtual ~ClassNodeList(); 50 virtual ~ClassNodeList();
51 51
52 bool nodeMatchesInlined(Element*) const; 52 bool nodeMatchesInlined(const Element&) const;
53 53
54 private: 54 private:
55 ClassNodeList(PassRefPtr<Node> rootNode, const AtomicString& classNames); 55 ClassNodeList(PassRefPtr<Node> rootNode, const AtomicString& classNames);
56 56
57 virtual bool nodeMatches(Element*) const OVERRIDE; 57 virtual bool nodeMatches(const Element&) const OVERRIDE;
58 58
59 SpaceSplitString m_classNames; 59 SpaceSplitString m_classNames;
60 AtomicString m_originalClassNames; 60 AtomicString m_originalClassNames;
61 }; 61 };
62 62
63 inline bool ClassNodeList::nodeMatchesInlined(Element* testNode) const 63 inline bool ClassNodeList::nodeMatchesInlined(const Element& testNode) const
64 { 64 {
65 if (!testNode->hasClass()) 65 if (!testNode.hasClass())
66 return false; 66 return false;
67 if (!m_classNames.size()) 67 if (!m_classNames.size())
68 return false; 68 return false;
69 // FIXME: DOM4 allows getElementsByClassName to return non StyledElement. 69 // FIXME: DOM4 allows getElementsByClassName to return non StyledElement.
70 // https://bugs.webkit.org/show_bug.cgi?id=94718 70 // https://bugs.webkit.org/show_bug.cgi?id=94718
71 if (!testNode->isStyledElement()) 71 if (!testNode.isStyledElement())
72 return false; 72 return false;
73 return testNode->classNames().containsAll(m_classNames); 73 return testNode.classNames().containsAll(m_classNames);
74 } 74 }
75 75
76 } // namespace WebCore 76 } // namespace WebCore
77 77
78 #endif // ClassNodeList_h 78 #endif // ClassNodeList_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698