Source/core/dom/ClassNodeList.cpp - Issue 141683004: Use more const references in HTMLCollection / LiveNodeList

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/dom/ClassNodeList.cpp

Issue 141683004: Use more const references in HTMLCollection / LiveNodeList (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « Source/core/dom/ClassNodeList.h ('k') | Source/core/dom/LiveNodeList.h » ('j') | Source/core/html/HTMLLabelElement.cpp » ('J')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.	2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.

3 * Copyright (C) 2007 David Smith (catfish.man@gmail.com)	3 * Copyright (C) 2007 David Smith (catfish.man@gmail.com)

4 *	4 *

5 * Redistribution and use in source and binary forms, with or without	5 * Redistribution and use in source and binary forms, with or without

6 * modification, are permitted provided that the following conditions	6 * modification, are permitted provided that the following conditions

7 * are met:	7 * are met:

8 *	8 *

9 * 1. Redistributions of source code must retain the above copyright	9 * 1. Redistributions of source code must retain the above copyright

10 * notice, this list of conditions and the following disclaimer.	10 * notice, this list of conditions and the following disclaimer.

(...skipping 29 matching lines...) Expand all Loading...
40 , m_classNames(classNames, document().inQuirksMode())	40 , m_classNames(classNames, document().inQuirksMode())

41 , m_originalClassNames(classNames)	41 , m_originalClassNames(classNames)

42 {	42 {

43 }	43 }

44	44

45 ClassNodeList::~ClassNodeList()	45 ClassNodeList::~ClassNodeList()

46 {	46 {

47 ownerNode()->nodeLists()->removeCacheWithAtomicName(this, ClassNodeListType, m_originalClassNames);	47 ownerNode()->nodeLists()->removeCacheWithAtomicName(this, ClassNodeListType, m_originalClassNames);

48 }	48 }

49	49

50 bool ClassNodeList::nodeMatches(Element* testNode) const	50 bool ClassNodeList::nodeMatches(const Element& testNode) const

51 {	51 {

52 return nodeMatchesInlined(testNode);	52 return nodeMatchesInlined(testNode);

53 }	53 }

54	54

55 } // namespace WebCore	55 } // namespace WebCore

OLD	NEW