Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 141683002: Add error messages in Daemon::Kill(). (Closed)

Created:
6 years, 11 months ago by Philippe
Modified:
6 years, 11 months ago
Reviewers:
bulach
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : s/device_forwarder/forwarder #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M tools/android/forwarder2/daemon.cc View 1 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Philippe
Hi Marcus, I still see the failure after we landed Digit's CL. I see a ...
6 years, 11 months ago (2014-01-17 11:42:35 UTC) #1
bulach
lgtm, go for it! thanks!
6 years, 11 months ago (2014-01-17 11:45:52 UTC) #2
Philippe
Thanks Marcus! On Fri, Jan 17, 2014 at 12:45 PM, <bulach@chromium.org> wrote: > lgtm, go ...
6 years, 11 months ago (2014-01-17 11:49:24 UTC) #3
Philippe
6 years, 11 months ago (2014-01-17 11:54:27 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r245495 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698