sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart - Issue 14168003: Implement implicit constructors in mixin applications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart

Issue 14168003: Implement implicit constructors in mixin applications. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Remove debug code and rebase Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sdk/lib/_internal/compiler/implementation/compiler.dart ('K') | « sdk/lib/_internal/compiler/implementation/compiler.dart ('k') | sdk/lib/_internal/compiler/implementation/elements/elements.dart » ('j') | sdk/lib/_internal/compiler/implementation/elements/elements.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart

diff --git a/sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart b/sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart

index 830fddf27d7be635f11c09feab8da0654a7710cd..c12bf96301af73693e802c77c9c6ee4222ce8a7b 100644

--- a/sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart

+++ b/sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart

@@ -280,7 +280,9 @@ class DartBackend extends Backend {

// field names used as named optionals into [fixedMemberNames].

for (final element in resolvedElements.keys) {

if (!element.isConstructor()) continue;

- for (final optional in element.functionSignature.optionalParameters) {

+ Link<Element> optionalParameters =

+ element.computeSignature(compiler).optionalParameters;

ahe 2013/04/15 13:36:46 This looks really bad. Why hasn't computeSignatur

karlklose 2013/04/25 11:25:53 It is not necessary, I forgot to delete it.

+ for (final optional in optionalParameters) {

if (optional.kind != ElementKind.FIELD_PARAMETER) continue;

fixedMemberNames.add(optional.name.slowToString());

}